From: Tom Tromey <tom@tromey.com>
To: Richard Bunt <richard.bunt@arm.com>
Cc: gdb-patches@sourceware.org, nd@arm.com
Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists
Date: Mon, 06 Aug 2018 19:07:00 -0000 [thread overview]
Message-ID: <87lg9jz55b.fsf@tromey.com> (raw)
In-Reply-To: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> (Richard Bunt's message of "Fri, 3 Aug 2018 10:32:44 +0100")
>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
Richard> Investigation revealed that EVAL_SKIP was not being handled correctly
Richard> for all types serviced by the OP_F77_UNDETERMINED_ARGLIST case in
Richard> evaluate_subexp_standard. While skipping an undetermined argument
Richard> list the type is resolved to be an integer (as this is what
Richard> evaluate_subexp returns when skipping) and so it was not possible to
Richard> delegate to the appropriate case (e.g. array, function call).
While I agree with Simon that this patch is fine, I think the intended
design of eval.c is that skipped expressions should still try to return
a value of the correct type when possible. The reason for this is that
the type is still sometimes needed, for example to compute the correct
type of a ?: ternary operator, which in turn could be used for overload
resolution.
Richard> While this patch allows a wider range of expressions to be evaluated, it
Richard> should be noted that this patch does not allow the skipping of arrays
Richard> which use Fortran array slicing, due to the inability of the debugger
Richard> to skip OP_RANGE.
This sounds like a bug to me.
Tom
next prev parent reply other threads:[~2018-08-06 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 9:32 Richard Bunt
2018-08-03 19:24 ` Simon Marchi
2018-08-06 16:35 ` Richard Bunt
2018-08-06 18:34 ` Simon Marchi
2018-08-06 19:07 ` Tom Tromey [this message]
2018-08-07 16:26 ` Richard Bunt
2018-08-07 17:40 ` Tom Tromey
2018-08-08 16:59 ` Richard Bunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg9jz55b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=richard.bunt@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).