From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124998 invoked by alias); 22 May 2018 14:49:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124988 invoked by uid 89); 22 May 2018 14:49:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=hoping, dangling X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.68.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 May 2018 14:49:32 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id DE82540E1D369 for ; Tue, 22 May 2018 09:49:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id L8bSfanVKlAdrL8bSf5rWZ; Tue, 22 May 2018 09:49:30 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:57962 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fL8bS-0014vu-M9; Tue, 22 May 2018 09:49:30 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning References: <1526999977-126638-1-git-send-email-brobecker@adacore.com> Date: Tue, 22 May 2018 14:58:00 -0000 In-Reply-To: <1526999977-126638-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Tue, 22 May 2018 10:39:36 -0400") Message-ID: <87lgcbg2yu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fL8bS-0014vu-M9 X-Source-Sender: 174-29-44-154.hlrn.qwest.net (pokyo) [174.29.44.154]:57962 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00558.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> There was a small bug in Tom's patch that caused the execution Joel> of the "catch assert" command to throw a C++ exception. Sorry about that. Joel> But at the same time, this leads me to believe we may have a weakness Joel> top.c::execute_command, which installs a cleanup, and "forgets" to Joel> discard it when C++ exceptions are raised. My view was always that dangling cleanups are nearly always bugs; with the exceptions being functions that either mention "cleanup" in the name or return a cleanup. I'm still hoping that we can just remove all cleanups and not have to deal with the issue any more. Tom