From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] Make '{add-,}symbol-file' not care about the position of command line arguments
Date: Thu, 30 Nov 2017 17:43:00 -0000 [thread overview]
Message-ID: <87lgin1x3g.fsf@redhat.com> (raw)
In-Reply-To: <776d2bfd-fc2c-030c-e277-1461360a54a6@redhat.com> (Pedro Alves's message of "Thu, 30 Nov 2017 17:37:45 +0000")
On Thursday, November 30 2017, Pedro Alves wrote:
> On 11/30/2017 05:26 PM, Sergio Durigan Junior wrote:
>
>>> (Another thing that I noticed but I'm kind of ignoring is the fact
>>> that gdb_test treats the question as optional gdb output, so
>>> pedantically gdb could stop outputting the question and answer
>>> "n" automatically and the testcase wouldn't notice.)
>>
>> Would you prefer if I made the tests answer "y" instead? Or maybe I'm
>> misunderstanding your concern.
>>
>
> Take a look at how gdb_test implements the question/response. The
> question argument is a question that GDB _may_ ask, not one that
> GDB _must_ ask.
>
> So pedantically if add-symbol-file's query ever becomes broken in a way
> that makes GDB simply automatically assume "n" without GDB printing
> the question in the first place, like:
>
> (gdb) add-symbol-file -s .text 0x200 $binfile 0x100
> Not confirmed.
> (gdb)
>
> then this:
>
> gdb_test "add-symbol-file -s .text 0x200 $binfile 0x100" \
> "Not confirmed\." \
> "add-symbol-file different -s .text, before file" \
> "add symbol table from file \"${binfile}\" at\r\n\t\.text_addr = x100\r\n\t\.text_addr = 0x200\r\n\\(y or n\\) " \
> "n"
>
> won't notice it, it'll still PASS.
>
> The usual way to test must-ask questions is to use
> one gdb_test_multiple up to the question, and another gdb_test for
> answering the question. Something like (untested):
>
> set test "add-symbol-file different -s .text, before file"
> gdb_test_multiple "add-symbol-file -s .text 0x200 $binfile 0x100" $test {
> -re "add symbol table from file \"${binfile}\" at\r\n\t\.text_addr = x100\r\n\t\.text_addr = 0x200\r\n\\(y or n\\) " {
> gdb_test "n" "Not confirmed\." $test
> }
> }
OK, I see what you mean. You obviously know that I copied the same
pattern present at gdb.base/relocate.exp (and many other tests, which
makes me frown a bit when I read "The usual way to test must-ask...").
I'll rewrite my tests to use the suggested way, then.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-11-30 17:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 20:54 [RFC/RFA] Add support for the --readnever command-line option (DWARF only) Joel Brobecker
2016-07-12 14:27 ` Yao Qi
2016-10-04 18:07 ` Pedro Alves
2017-11-23 0:54 ` [PATCH v2] " Sergio Durigan Junior
2017-11-23 12:09 ` Pedro Alves
2017-11-23 17:21 ` Sergio Durigan Junior
2017-11-23 17:29 ` Pedro Alves
2017-11-24 4:54 ` Sergio Durigan Junior
2017-11-24 13:18 ` Pedro Alves
2017-11-24 20:27 ` Sergio Durigan Junior
2017-11-27 19:13 ` Pedro Alves
2017-11-29 0:59 ` Sergio Durigan Junior
2017-11-29 12:23 ` Pedro Alves
2017-11-23 15:59 ` Eli Zaretskii
2017-11-23 19:36 ` Sergio Durigan Junior
2016-10-04 18:06 ` [RFC/RFA] " Pedro Alves
2017-11-24 23:01 ` [PATCH v2] Add support for the --readnever command-line option Sergio Durigan Junior
2017-11-25 7:33 ` Eli Zaretskii
2017-11-25 16:41 ` Sergio Durigan Junior
2017-11-25 17:16 ` Eli Zaretskii
2017-11-29 1:21 ` [PATCH v3] Add support for the readnever concept Sergio Durigan Junior
2017-11-29 3:39 ` Eli Zaretskii
2017-11-29 12:25 ` Pedro Alves
2017-11-29 18:43 ` Sergio Durigan Junior
2017-11-29 21:45 ` [PATCH] Make 'symbol-file' not care about the position of command line arguments Sergio Durigan Junior
2017-11-29 22:26 ` Pedro Alves
2017-11-29 22:42 ` Sergio Durigan Junior
2017-11-29 23:15 ` Pedro Alves
2017-11-30 0:08 ` Sergio Durigan Junior
2017-11-30 0:34 ` Pedro Alves
2017-11-30 4:07 ` Sergio Durigan Junior
2017-11-30 4:25 ` [PATCH v2] Make '{add-,}symbol-file' " Sergio Durigan Junior
2017-11-30 10:57 ` Pedro Alves
2017-11-30 12:38 ` Sergio Durigan Junior
2017-11-30 12:49 ` Pedro Alves
2017-11-30 13:06 ` Sergio Durigan Junior
2017-11-30 13:33 ` [PATCH v3] " Sergio Durigan Junior
2017-11-30 15:01 ` Pedro Alves
2017-11-30 17:26 ` Sergio Durigan Junior
2017-11-30 17:37 ` Pedro Alves
2017-11-30 17:43 ` Sergio Durigan Junior [this message]
2017-11-30 17:50 ` Pedro Alves
2017-11-30 20:00 ` [PATCH v4] " Sergio Durigan Junior
2017-12-01 12:11 ` Pedro Alves
2017-12-01 17:41 ` Sergio Durigan Junior
2017-12-01 21:45 ` Pedro Alves
2017-12-01 22:02 ` Sergio Durigan Junior
2017-11-30 0:25 ` [PATCH v4] Add support for the readnever concept Sergio Durigan Junior
2017-11-30 11:53 ` Pedro Alves
2017-12-01 4:35 ` Sergio Durigan Junior
2017-12-01 12:43 ` Pedro Alves
2017-12-01 17:19 ` Tom Tromey
2017-12-01 17:21 ` Sergio Durigan Junior
2017-12-01 20:00 ` Pedro Alves
2017-12-01 22:16 ` [PATCH v5] " Sergio Durigan Junior
2017-12-01 23:19 ` Pedro Alves
2017-12-02 2:31 ` Sergio Durigan Junior
2017-12-02 8:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgin1x3g.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).