From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120512 invoked by alias); 24 Oct 2017 13:55:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120496 invoked by uid 89); 24 Oct 2017 13:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=claim X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Oct 2017 13:55:48 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id 38088215DC6 for ; Tue, 24 Oct 2017 07:55:47 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id RRvk1w0022f2jeq01RvnQ1; Tue, 24 Oct 2017 07:55:47 -0600 X-Authority-Analysis: v=2.2 cv=K4VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=VnNF1IyMAAAA:8 a=y25uhUQMxMUmcmPxCXoA:9 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:59650 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e6zgF-0035xF-Px; Tue, 24 Oct 2017 07:55:43 -0600 From: Tom Tromey To: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), gdb-patches@sourceware.org, tom@tromey.com, simon.marchi@ericsson.com Subject: Re: [RFA 1/6] Use std::vector in end_symtab_get_static_block References: <20171023161620.99288D80753@oc3748833570.ibm.com> Date: Tue, 24 Oct 2017 13:55:00 -0000 In-Reply-To: <20171023161620.99288D80753@oc3748833570.ibm.com> (Ulrich Weigand's message of "Mon, 23 Oct 2017 18:16:20 +0200 (CEST)") Message-ID: <87lgk03b1f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e6zgF-0035xF-Px X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:59650 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00745.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> Now, the reason why we re-sort pending_blocks here is to allow Ulrich> for object code reordering (hot/cold sections and the like). Ulrich> But this type of reordering never actually affects inline function Ulrich> relationships. So it may be that just using stable_sort here is Ulrich> actually the *correct* fix ... I tend to think so as well, for the reasons you mentioned. glibc doesn't claim that qsort is stable, but maybe it is in practice sometimes? Tom