From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68506 invoked by alias); 1 Aug 2017 21:52:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68488 invoked by uid 89); 1 Aug 2017 21:52:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Aug 2017 21:52:20 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id 7A728216D11 for ; Tue, 1 Aug 2017 15:41:32 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id rxhV1v0052f2jeq01xhYgx; Tue, 01 Aug 2017 15:41:32 -0600 X-Authority-Analysis: v=2.2 cv=aJeAkf1m c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=KeKAF7QvOSUA:10 a=8Gcnap1Gt1jnAF1JeLIA:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:35858 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dceuu-002KrW-Sb; Tue, 01 Aug 2017 15:41:28 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFA 09/23] Remove close cleanup References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-10-tom@tromey.com> <87iniom59v.fsf@tromey.com> Date: Tue, 01 Aug 2017 21:52:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 31 Jul 2017 21:08:26 +0200") Message-ID: <87lgn3c6ev.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dceuu-002KrW-Sb X-Source-Sender: 174-29-39-24.hlrn.qwest.net (pokyo) [174.29.39.24]:35858 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-08/txt/msg00018.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Instead of finding a solution to preserve errno, I think we should Simon> return it explicitly when needed, it would be more robust and easier Simon> to follow the trail where the value comes from. That would mean Simon> changing Simon> static enum mnsh_fs_code Simon> linux_mntns_access_fs (pid_t pid) Simon> to Simon> static enum mnsh_fs_code Simon> linux_mntns_access_fs (pid_t pid, int *errnop) Simon> and possibly others. In that case, *ERRNOP would be set if Simon> MNSH_FS_ERROR is returned. I think somebody else should take this then. I will see if I can drop this patch from the series. Tom