From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 508 invoked by alias); 19 Jul 2017 22:52:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 497 invoked by uid 89); 19 Jul 2017 22:52:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: outbound-ss-1812.hostmonster.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO outbound-ss-1812.hostmonster.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Jul 2017 22:52:52 +0000 Received: from cmgw2 (cmgw3 [10.0.90.83]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 0BAEC17662F for ; Wed, 19 Jul 2017 16:26:10 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id mmS61v00g2f2jeq01mS9V4; Wed, 19 Jul 2017 16:26:10 -0600 X-Authority-Analysis: v=2.2 cv=UvYTD64B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=20KFwNOVAAAA:8 a=aHWw9VhBpW3gEDgPQvQA:9 Received: from 174-16-124-214.hlrn.qwest.net ([174.16.124.214]:42554 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dXxPy-0017OI-QA; Wed, 19 Jul 2017 16:26:06 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 23/23] Use gdb_argv_up in Python References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-24-tom@tromey.com> <32dc20d7-52ef-1599-d1fa-1ec299fe291c@redhat.com> Date: Wed, 19 Jul 2017 22:52:00 -0000 In-Reply-To: <32dc20d7-52ef-1599-d1fa-1ec299fe291c@redhat.com> (Pedro Alves's message of "Mon, 5 Jun 2017 17:29:00 +0100") Message-ID: <87lgnkm5c3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dXxPy-0017OI-QA X-Source-Sender: 174-16-124-214.hlrn.qwest.net (bapiya) [174.16.124.214]:42554 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-07/txt/msg00297.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> if (self->enumeration[i] == NULL) Pedro> I think you need to adjust the if too: Pedro> if (enumeration[i] == NULL) Thanks, I made this fix. >> + self->enumeration = const_cast (enumeration.release ()); Pedro> If I'm reading the code correctly, "self->enumeration" is never Pedro> released (by design), right? Yes. I think it could be destroyed if the command is deleted, but I can't remember now if that can happen; and anyway if it can it must be a weird thing to do. Tom