From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31319 invoked by alias); 16 Apr 2017 17:32:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30883 invoked by uid 89); 16 Apr 2017 17:32:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=correction X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Apr 2017 17:32:04 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 07FB681253; Sun, 16 Apr 2017 17:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 07FB681253 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 07FB681253 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2B9417968; Sun, 16 Apr 2017 17:32:04 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches Subject: Re: [PATCH v2] C++ify gdb/common/environ.c References: <20170413040455.23996-1-sergiodj@redhat.com> <20170415185053.31827-1-sergiodj@redhat.com> <7da1e54fc8f25b39e1e4c9558a77e71a@polymtl.ca> Date: Sun, 16 Apr 2017 17:32:00 -0000 In-Reply-To: <7da1e54fc8f25b39e1e4c9558a77e71a@polymtl.ca> (Simon Marchi's message of "Sun, 16 Apr 2017 01:09:35 -0400") Message-ID: <87lgr0i7hn.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00489.txt.bz2 On Sunday, April 16 2017, Simon Marchi wrote: > On 2017-04-15 14:50, Sergio Durigan Junior wrote: >> As part of the preparation necessary for my upcoming task, I'd like to >> propose that we turn gdb_environ into a class. The approach taken >> here is simple: the class gdb_environ contains everything that is >> needed to manipulate the environment variables. These variables are >> stored in two data structures: an unordered_set, good because lookups >> are O(n), and an std::vector, which can be converted to a >> 'char **' and passed as argument to functions that need it. > > Forgot to mention (probably a typo) that lookups in the map are O(1) > on average. If they were O(n), it wouldn't be better than looking up > in a vector :). You're right, they're O(1). I was thinking about the vector when I wrote. Thanks for the correction! -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/