From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix thinko on last commit
Date: Mon, 20 Feb 2017 13:08:00 -0000 [thread overview]
Message-ID: <87lgt1m2me.fsf@redhat.com> (raw)
In-Reply-To: <20170220130451.27942-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Mon, 20 Feb 2017 08:04:51 -0500")
On Monday, February 20 2017, I wrote:
> On fork-child.c:trace_start_error, va_end should refer to 'ap', not
> 'args. This fixes it.
I've pushed this as obvious.
> Sorry about the breakage.
>
> gdb/ChangeLog:
> 2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
>
> PR gdb/16188
> * fork-child.c (trace_start_error): Fix thinko. va_end should
> refer to 'ap', not 'args'.
> ---
> gdb/ChangeLog | 6 ++++++
> gdb/fork-child.c | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index cf68c7e..610755c 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,4 +1,10 @@
> 2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
> +
> + PR gdb/16188
> + * fork-child.c (trace_start_error): Fix thinko. va_end should
> + refer to 'ap', not 'args'.
> +
> +2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
> Pedro Alves <palves@redhat.com>
>
> PR gdb/16188
> diff --git a/gdb/fork-child.c b/gdb/fork-child.c
> index f6256fb..dc2a314 100644
> --- a/gdb/fork-child.c
> +++ b/gdb/fork-child.c
> @@ -120,7 +120,7 @@ trace_start_error (const char *fmt, ...)
> fprintf_unfiltered (gdb_stderr, "Could not trace the inferior "
> "process.\nError: ");
> vfprintf_unfiltered (gdb_stderr, fmt, ap);
> - va_end (args);
> + va_end (ap);
>
> gdb_flush (gdb_stderr);
> _exit (0177);
> --
> 2.9.3
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2017-02-20 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 20:19 [PATCH] PR gdb/16188: Verify PTRACE_TRACEME succeeded Sergio Durigan Junior
2017-02-17 10:48 ` Pedro Alves
2017-02-18 4:55 ` Sergio Durigan Junior
2017-02-18 5:09 ` Sergio Durigan Junior
2017-02-20 12:19 ` Pedro Alves
2017-02-20 12:51 ` Sergio Durigan Junior
2017-02-20 13:05 ` [PATCH] Fix thinko on last commit Sergio Durigan Junior
2017-02-20 13:08 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgt1m2me.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).