From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102389 invoked by alias); 20 Feb 2017 13:08:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102377 invoked by uid 89); 20 Feb 2017 13:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1515 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Feb 2017 13:08:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7378C80F9B for ; Mon, 20 Feb 2017 13:08:11 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1KD8A5h028017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 20 Feb 2017 08:08:11 -0500 From: Sergio Durigan Junior To: GDB Patches Subject: Re: [PATCH] Fix thinko on last commit References: <87tw7pm3dw.fsf@redhat.com> <20170220130451.27942-1-sergiodj@redhat.com> X-URL: http://blog.sergiodj.net Date: Mon, 20 Feb 2017 13:08:00 -0000 In-Reply-To: <20170220130451.27942-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Mon, 20 Feb 2017 08:04:51 -0500") Message-ID: <87lgt1m2me.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00542.txt.bz2 On Monday, February 20 2017, I wrote: > On fork-child.c:trace_start_error, va_end should refer to 'ap', not > 'args. This fixes it. I've pushed this as obvious. > Sorry about the breakage. > > gdb/ChangeLog: > 2017-02-20 Sergio Durigan Junior > > PR gdb/16188 > * fork-child.c (trace_start_error): Fix thinko. va_end should > refer to 'ap', not 'args'. > --- > gdb/ChangeLog | 6 ++++++ > gdb/fork-child.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index cf68c7e..610755c 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,4 +1,10 @@ > 2017-02-20 Sergio Durigan Junior > + > + PR gdb/16188 > + * fork-child.c (trace_start_error): Fix thinko. va_end should > + refer to 'ap', not 'args'. > + > +2017-02-20 Sergio Durigan Junior > Pedro Alves > > PR gdb/16188 > diff --git a/gdb/fork-child.c b/gdb/fork-child.c > index f6256fb..dc2a314 100644 > --- a/gdb/fork-child.c > +++ b/gdb/fork-child.c > @@ -120,7 +120,7 @@ trace_start_error (const char *fmt, ...) > fprintf_unfiltered (gdb_stderr, "Could not trace the inferior " > "process.\nError: "); > vfprintf_unfiltered (gdb_stderr, fmt, ap); > - va_end (args); > + va_end (ap); > > gdb_flush (gdb_stderr); > _exit (0177); > -- > 2.9.3 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/