From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH V3 1/9] Adapt `info probes' to support printing probes of different types.
Date: Fri, 14 Nov 2014 23:08:00 -0000 [thread overview]
Message-ID: <87lhnd754a.fsf@redhat.com> (raw)
In-Reply-To: <5465F7A5.8040207@redhat.com> (Pedro Alves's message of "Fri, 14 Nov 2014 12:37:57 +0000")
On Friday, November 14 2014, Pedro Alves wrote:
> On 10/31/2014 06:56 PM, Sergio Durigan Junior wrote:
>> Also, any particular reason why you did not create a field "type" inside
>> "struct probe", instead of making a function that returns the string? I
>> consider the field would be simpler (i.e., not pollute the probe_ops
>> structure), and it could be set when creating the probes.
>
> Not sure I understood it (and probably doesn't matter much), seems like
> that'd waste memory storing the same info over and over?
We would be wasting sizeof (char *) for each probe created, indeed, but
I think this is clearer (also for debugging purposes) than having all
the necessary machinery to call a function that will return the same
info...
Anyway, I won't oppose the current approach too, I was just curious :-P.
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-11-14 23:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 13:45 [PATCH V3 0/9] Add support for DTrace USDT probes to gdb Jose E. Marchesi
2014-10-28 13:45 ` [PATCH V3 4/9] New gdbarch functions: dtrace_parse_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe Jose E. Marchesi
2014-10-31 19:06 ` Sergio Durigan Junior
2014-10-28 13:45 ` [PATCH V3 1/9] Adapt `info probes' to support printing probes of different types Jose E. Marchesi
2014-10-31 18:56 ` Sergio Durigan Junior
2014-11-14 12:38 ` Pedro Alves
2014-11-14 23:08 ` Sergio Durigan Junior [this message]
2014-11-17 16:36 ` Pedro Alves
2014-11-17 17:45 ` Sergio Durigan Junior
2014-10-28 13:45 ` [PATCH V3 9/9] Announce the DTrace USDT probes support in NEWS Jose E. Marchesi
2014-10-28 13:45 ` [PATCH V3 5/9] New probe type: DTrace USDT probes Jose E. Marchesi
2014-10-31 20:03 ` Sergio Durigan Junior
2014-10-28 13:45 ` [PATCH V3 6/9] Support for DTrace USDT probes in x86_64 targets Jose E. Marchesi
2014-10-31 20:28 ` Sergio Durigan Junior
2014-10-28 13:45 ` [PATCH V3 7/9] Simple testsuite for DTrace USDT probes Jose E. Marchesi
2014-11-13 23:19 ` Sergio Durigan Junior
2014-11-14 13:03 ` Pedro Alves
2014-10-28 13:45 ` [PATCH V3 8/9] Documentation " Jose E. Marchesi
2014-10-28 13:45 ` [PATCH V3 3/9] New commands `enable probe' and `disable probe' Jose E. Marchesi
2014-10-31 19:04 ` Sergio Durigan Junior
2014-10-28 13:45 ` [PATCH V3 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c Jose E. Marchesi
2014-10-31 19:46 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhnd754a.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).