Re: [PATCH 4/4] Update documentation on catching a group of related syscalls.

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Sunday, November 02 2014, Gabriel Krisman Bertazi wrote:

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 649c29e..edea1ff 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -60,6 +60,11 @@ SGI Irix-6.x				mips-*-irix6*
>  VAX running (4.2 - 4.3 Reno) BSD 	vax-*-bsd*
>  VAX running Ultrix 			vax-*-ultrix*
>  
> +* Catch syscall catches groups of related syscalls.
> +
> +  Catch syscall command supports catching a group of related
> +  syscalls using the 'group:' or 'g:' prefix.
> +

Yay, thanks for the patch.  Almost there!

Hmm, I would prefer not to use capital letters when naming commands.
How about:

* The "catch syscall" command now supports catching groups of relates
  system calls, using the "group:" or "g:" prefixes.

?

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 15c2908..ca16e11 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -4254,7 +4254,7 @@ A call to @code{exec}.  This is currently only available for HP-UX
>  and @sc{gnu}/Linux.
>  
>  @item syscall
> -@itemx syscall @r{[}@var{name} @r{|} @var{number}@r{]} @dots{} 
> +@itemx syscall @r{[}@var{name} @r{|} @var{number} @r{|} @var{group:groupname} @r{|} @var{g:groupname}@r{]} @dots{}
>  @kindex catch syscall
>  @cindex break on a system call.
>  A call to or return from a system call, a.k.a.@: @dfn{syscall}.  A
> @@ -4289,6 +4289,12 @@ may be useful if @value{GDBN}'s database does not have the complete
>  list of syscalls on your system (e.g., because @value{GDBN} lags
>  behind the OS upgrades).
>  
> +You may specify a group of related syscalls to be caught at once
> +using the @code{group:} syntax (@code{g:} is a shorter equivalent.).
> +For instance, on some platforms GDB allows you to catch all network
> +related syscalls, by passing the argument @code{group:network} to
> +@code{catch syscall}.
> +

Aside from Eli's comments, I would really like to see an example of how
to use this feature in the manual.

Thanks,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/