From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109265-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6391 invoked by alias); 14 Jan 2014 19:23:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 6381 invoked by uid 89); 14 Jan 2014 19:23:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 19:23:49 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EJNmUJ011516	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 14 Jan 2014 14:23:48 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0EJNl7g016777	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 14 Jan 2014 14:23:48 -0500
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 27/32] convert to_insert_mask_watchpoint
References: <1389640367-5571-1-git-send-email-tromey@redhat.com>	<1389640367-5571-28-git-send-email-tromey@redhat.com>	<52D58CE4.4090105@redhat.com>
Date: Tue, 14 Jan 2014 19:23:00 -0000
In-Reply-To: <52D58CE4.4090105@redhat.com> (Pedro Alves's message of "Tue, 14	Jan 2014 19:15:48 +0000")
Message-ID: <87lhyiv03g.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00467.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 01/13/2014 07:12 PM, Tom Tromey wrote:
>> +    char *(*to_pid_to_str) (struct target_ops *, ptid_t)
>> +      TARGET_DEFAULT_FUNC (dummy_pid_to_str);

Pedro> This use of "dummy" in the default looked odd to me.
Pedro> I'd suggest renaming it to default_pid_to_str (now or at some
Pedro> point), in line with the other default methods.

I made this change.

Tom