* [PATCH] single-stepping over unconditional branches with zero offset
@ 2013-10-18 14:13 Jose E. Marchesi
2013-11-06 21:05 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Jose E. Marchesi @ 2013-10-18 14:13 UTC (permalink / raw)
To: gdb-patches
Hi.
The patch below removes an assertion from sparc_analyze_control_transfer
that prevents single-stepping over unconditional branch instruction with
PC-relative offsets of zero:
b (%xcc|%icc), 0
nop
or
b,a (%xcc|%icc), 0
This was making a test in gdb.base/random-signal.exp to fail.
Tested on sparc64-unknown-linux-gnu. Now random-signal.exp passes. No
visible regressions running the testsuite.
2013-10-18 Jose E. Marchesi <jose.marchesi@oracle.com>
* sparc-tdep.c (sparc_analyze_control_transfer): Assertion
removed to allow analyzing unconditional branch instructions
with PC-relative offsets of zero.
Index: sparc-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-tdep.c,v
retrieving revision 1.233
diff -u -r1.233 sparc-tdep.c
--- sparc-tdep.c 24 Jun 2013 22:18:32 -0000 1.233
+++ sparc-tdep.c 18 Oct 2013 13:09:14 -0000
@@ -1538,7 +1538,6 @@
if (X_A (insn))
*npc = 0;
- gdb_assert (offset != 0);
return pc + offset;
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] single-stepping over unconditional branches with zero offset
2013-10-18 14:13 [PATCH] single-stepping over unconditional branches with zero offset Jose E. Marchesi
@ 2013-11-06 21:05 ` Tom Tromey
2013-11-07 11:43 ` Jose E. Marchesi
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2013-11-06 21:05 UTC (permalink / raw)
To: Jose E. Marchesi; +Cc: gdb-patches
>>>>> "Jose" == Jose E Marchesi <jose.marchesi@oracle.com> writes:
Jose> 2013-10-18 Jose E. Marchesi <jose.marchesi@oracle.com>
Jose> * sparc-tdep.c (sparc_analyze_control_transfer): Assertion
Jose> removed to allow analyzing unconditional branch instructions
Jose> with PC-relative offsets of zero.
Not really my area, but this one seems ok to me.
Please put it in.
You should ping your other patches.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] single-stepping over unconditional branches with zero offset
2013-11-06 21:05 ` Tom Tromey
@ 2013-11-07 11:43 ` Jose E. Marchesi
0 siblings, 0 replies; 3+ messages in thread
From: Jose E. Marchesi @ 2013-11-07 11:43 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
>>>>> "Jose" == Jose E Marchesi <jose.marchesi@oracle.com> writes:
Jose> 2013-10-18 Jose E. Marchesi <jose.marchesi@oracle.com>
Jose> * sparc-tdep.c (sparc_analyze_control_transfer): Assertion
Jose> removed to allow analyzing unconditional branch instructions
Jose> with PC-relative offsets of zero.
Not really my area, but this one seems ok to me.
Please put it in.
Pushed as commit d52cd232cb3a7a9f6e6857110d9119c1675d2d32.
http://sourceware.org/ml/gdb-patches/2013-10/msg00561.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-07 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-18 14:13 [PATCH] single-stepping over unconditional branches with zero offset Jose E. Marchesi
2013-11-06 21:05 ` Tom Tromey
2013-11-07 11:43 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).