public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: gdb-patches@sourceware.org, patches@linaro.org
Subject: Re: [PATCH] testsuite/gdb.dwarf2: Enable dw2-error.exp tests for arm targets
Date: Mon, 22 Jul 2013 16:06:00 -0000	[thread overview]
Message-ID: <87li4y7f69.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANW4E-2JhgU6rNJApL8g_yB1EWWMXKodsbbk9Pwt76e=SKGsMA@mail.gmail.com>	(Omair Javaid's message of "Mon, 22 Jul 2013 08:16:30 +0500")

>>>>> "Omair" == Omair Javaid <omair.javaid@linaro.org> writes:

Omair> dw2-error.exp is not run for arm targets because this test has been
Omair> written in x86 assembly language. This patch adds ARM version of
Omair> assembly code required to run dw2-error.exp tests on arm targets.
Omair> Attached patch is tested on ARMv7 and x86_64 targets.


Omair> 2013-07-22  Omair Javaid  <Omair.Javaid@linaro.org>

Omair>         * gdb.dwarf2/dw2-error.S: Adding ARM assembly code.

I think it would be just as easy to change this test to use the DWARF
assembler (which didn't exist when the test was first written).  Then
the test case could work on any arch.

Tom

  reply	other threads:[~2013-07-22 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  3:16 Omair Javaid
2013-07-22 16:06 ` Tom Tromey [this message]
2013-09-19 15:11   ` Omair Javaid
2013-09-19 18:37     ` Tom Tromey
2013-09-26 11:13       ` Omair Javaid
2013-09-27 19:56         ` Tom Tromey
2013-10-01  9:48           ` Omair Javaid
2013-10-01 10:05             ` Abid, Hafiz
2013-10-01 15:20               ` Tom Tromey
2013-12-02 20:43                 ` Omair Javaid
2013-12-03 20:37                   ` Tom Tromey
2013-10-01 15:19             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li4y7f69.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=omair.javaid@linaro.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).