Re: [PATCH 1/3] [gdb/exp] Fix target type of complex long double on arm

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> For arm-linux, complex long double is 16 bytes, so the target type is assumed
Tom> to be 8 bytes, which is handled by the "case 64", which gets us double
Tom> instead of long double.

Tom> Fix this by searching for "long" in the name_hint parameter, and using long
Tom> double instead.

Can you file a compiler bug report about this and then put the link in a
comment?

Does this same problem occur for scalars of type double -vs- long double?
If so then maybe gdb should just accept that this target is kind of
broken in this way.

Tom> +	  /* If both "double" and "long double" are 8 bytes, choose "double"
Tom> +	     for "complex double" and "long double" for "complex long
Tom> +	     double".  */
Tom> +	  if (builtin_type (gdbarch)->builtin_long_double->length () == 8
Tom> +	      && name_hint != nullptr && *name_hint != '\0'

I don't think the \0 part of this check is needed.

Tom