From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 01AF53858D35 for ; Tue, 7 May 2024 15:05:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01AF53858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01AF53858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715094333; cv=none; b=fF59DFrvT8CfHkxoJD2SUpNoMBwZbwO+1ZfTm1cvycIy1TPvsSPfoteAwO7FyalFL2yBUNAuhwwsQdeouONmYSHacS4WPsQIb0NcP1W6+nvwxeGbIVZxqIeMpgoNkxaLkNh4LqkHlh/1lhXRG1Gy3bh6NAK4rSSzuax5PcTlPcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715094333; c=relaxed/simple; bh=CKGzbU66dZ+Ahtit9y3oy0Bhov2g7lPLXcQ34xrr64U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WjpR/Ve13oeqCjzo15k9KoAu5Cvdl+0eufCh7OHzA0fveE4UGnZQFocCvBlrkCA0622ppfBdCzTGLrbQLLYykufuWMdLZSln1fTz5gd+bh9n5nrZCJpLF2iFKYpQF83ASdCv3JVwjx+eF3TYNlm0v2s8EKR//H+Jcd1cJiaeV1M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715094330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UIx36h7oRkQokEIjVBp4R2BDstG3LRnZ/qhE8hsJ9oY=; b=NG892F9f3d3KR3Rdg5MBj8aW2N4ebMDuj4X7Zx6KOA7OUuF0g8jJF+v01j4buKZMBiHBFM teKcvJe+ZayM8Y+Gez0LgRseAH0pnsoka+xLTW0+WaNCJ2xOErhpXKyb1nXV4U7eIID8+V i+KDlXXLedCM/nsNdfNq63V+M6T0lsY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-72p6mF6pNG-NvavwawGj7A-1; Tue, 07 May 2024 11:05:29 -0400 X-MC-Unique: 72p6mF6pNG-NvavwawGj7A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41a370b6acdso17097415e9.2 for ; Tue, 07 May 2024 08:05:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715094328; x=1715699128; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UIx36h7oRkQokEIjVBp4R2BDstG3LRnZ/qhE8hsJ9oY=; b=qVJCCLABUwigd2RsQYcmPHef5rZbiSDTZHdXm11u2wDbHQOR89pgZcNaD/cCF3URkq 6OmNeZjp8dpavxCaQ5o1vDuior4zmsR4kfsyt9uCPgfVFu0wNh+z1ApE7ikQdNBJIsfM HRMEKUuCTzyadhZCruH6fxlLkTpv/fMyHDOSEAaHzcSGXURfMqqAYn/R0sFTci+W5cqd pwjCF2OQvOK6s9PyTS2o2NkdxlkxnHGDYKp+qpHX4xHVpw8nm1J/kdSqNREX3RbOUTHu LqzXN7+31mYJ5PCj92DGy43FJXtzcKYPUIRwfW/k4kNBu/JM5UdoEqPzPYFoXZ+flBhi n1BA== X-Forwarded-Encrypted: i=1; AJvYcCUtR9x8ulDV9VMVOpzqOvuQ4bDaGdEx8vFGW6Jp0raOk7dI8kQEEH31zE3WXXA73+DjRFuqAwqlDDsFBHMTEErqxpN16NE6b6jnLg== X-Gm-Message-State: AOJu0YwAxCaTG3+9x0Ob0e668dA9wfcRqdFjgjF+aNmZ6jXpgObpe7SR LmonpDA4fmJrOyfhB9/xGH4VeVucjoCBdqFnvYGZQ2W3x0oZLn5pqczF4PXicFA9dV1Xzkuo5Q3 rvKchzPnUQQtNGfZrOkyrWvItLdkcbeUNaBp8PTfNkvLwTAiY/iYqLjZwy9RSNer2Szw= X-Received: by 2002:a05:600c:4f93:b0:41b:c24c:8a2a with SMTP id 5b1f17b1804b1-41f71cc4e41mr732105e9.13.1715094327575; Tue, 07 May 2024 08:05:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmSFMa9zX5Zpk1RgbtLPJs5xB8giO41fHn7EwTT9YQsYw7SXDaqaSlwbdriu6ZlGK92zfVnw== X-Received: by 2002:a05:600c:4f93:b0:41b:c24c:8a2a with SMTP id 5b1f17b1804b1-41f71cc4e41mr731855e9.13.1715094327057; Tue, 07 May 2024 08:05:27 -0700 (PDT) Received: from localhost ([31.111.84.240]) by smtp.gmail.com with ESMTPSA id k8-20020a05600c1c8800b00418a6d62ad0sm23830376wms.34.2024.05.07.08.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 08:05:25 -0700 (PDT) From: Andrew Burgess To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: John Baldwin Subject: RE: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations In-Reply-To: References: <451f76b4ea105af2def7e62d78662a647e809e73.1714143669.git.aburgess@redhat.com> Date: Tue, 07 May 2024 16:05:24 +0100 Message-ID: <87msp1u0gb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Willgerodt, Felix" writes: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Freitag, 26. April 2024 17:02 >> To: gdb-patches@sourceware.org >> Cc: Andrew Burgess ; Willgerodt, Felix >> ; John Baldwin >> Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations >> >> Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no >> longer needed. These are: >> >> 1. 'init_registers_amd64_linux' - the comment claims this function >> is auto generated, but I don't believe that this is still the case. >> Also the function is not used in this file, >> >> 2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any >> more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but >> neither are used in this file, so lets remove the declaration. >> >> The amd64 in-process-agent still builds fine after this commit. >> >> There should be no user visible changes after this commit. >> --- >> gdbserver/linux-amd64-ipa.cc | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc >> index 13c8a5bb360..a6346750f49 100644 >> --- a/gdbserver/linux-amd64-ipa.cc >> +++ b/gdbserver/linux-amd64-ipa.cc >> @@ -23,10 +23,6 @@ >> #include "linux-x86-tdesc.h" >> #include "gdbsupport/x86-xstate.h" >> >> -/* Defined in auto-generated file amd64-linux.c. */ >> -void init_registers_amd64_linux (void); >> -extern const struct target_desc *tdesc_amd64_linux; >> - >> /* fast tracepoints collect registers. */ >> >> #define FT_CR_RIP 0 >> -- >> 2.25.4 > > Approved-By: Felix Willgerodt Given this patch is pretty disjoint from the rest of the series I've gone ahead and pushed just this patch. Thanks, Andrew