From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5FFD93858D20 for ; Wed, 17 Apr 2024 13:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FFD93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5FFD93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713361742; cv=none; b=wE2NmSQgzsS2uA+78DtUsLj5PVbacl8b2tBfJ9L+G4QLzx8PxGXj/dhny/YIHxT8ZYdAiY1DTQi9kSGu+IZepr4tNHS/QKOUFk+Lu+bzL5HTbEnJ89q7pwYdZMrPd4lsH3MLUsscAWrg8cOkRpC4M8dBSuubvzU/FVvo51wT7fI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713361742; c=relaxed/simple; bh=DjeK5Tt3VQD8WksJ/gvYm1CtaCIbAYJ33p9YtYxBnhg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ht4/mTxJjDrOug6xtlSZr3NDJbmm3esQGAUstKq+WFPO7mqFCSPhUMPyC5n/POuwmlI7YOtZSrQhrL+Af7gomoCmp2y/oMTWZythQeAjcKel6xxIySSSWEn3LAJxtikJwEtnrHiaIFtaxrT9m7PzewvlMtIRjo/zbd4kcqUtSZ4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713361740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LzPK2/dgc7lVSuTKb5WNH8J3/iub8pKtZwg/oyA3IBs=; b=Hj3YkQj+bwfUMxPmWsoEA9z39RBvWf7CKT+szNsRIC6GHtMmwpZCSCS9d3FG2WfuSMFk70 9U1xZntFDv/SrCccrjYY8xYQwgc2Blxq5wZGDV9wZwRk0N6ijh9hTfEDitlBhgWMfWTsh0 8LJ1g43vhtQ1pG2Bb9VDIGPQvgwaGx0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-w4AcIQP7MRCEmlu1Glm61A-1; Wed, 17 Apr 2024 09:48:58 -0400 X-MC-Unique: w4AcIQP7MRCEmlu1Glm61A-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343c86edeb7so3587137f8f.1 for ; Wed, 17 Apr 2024 06:48:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713361736; x=1713966536; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LzPK2/dgc7lVSuTKb5WNH8J3/iub8pKtZwg/oyA3IBs=; b=LuaxZYkPpbRkBjQxqyKwn8evR5ppEuvcuisBwfUd3d36Hq9y0qnbDH6Dq8M2bRRbbH MYH9/DOslnh04Jbf/0BgSF6ht9jS07rmwxQ0aE6zQiS0nxUHx2oKUDQzS+24RSIcB6A7 cTbUEpS+4pVAdN0U6kuCM5jRfEWz07AVtn87OqHN4N21RIVseTCrXWv4h3ZpcJpyRx0S WHVwut2g/+Wi5r0munpijcdwhs9t7EK1zxagT8yru9DoVlkbo3yYNMFIOO971uc+pUIR RNkxh3W1hLO3dUh7Md9v2iHtiBzZhGwSJnrxLqgx7KGT7OpOIBr8r4CVjloOeJAA+SFW hQeg== X-Gm-Message-State: AOJu0YxURpBIHc1LWOefjW0tWrw3s8CKLBCZ36VBdwQPwA9XzDV+akP+ oBMtC7CB9DvuafC+MdWp8Fco7fgJWf3LliXQtsRi8pr1Rji3B5CLc65AICHUQ4SjTKvryt74J7o 1HkLxyFmbr21wJ3Pe+pNhW/BOGdSNhiHqttJYBBt2/aCm7s12PU/vxUmMp1tqQiP5Uf4= X-Received: by 2002:adf:f44f:0:b0:345:223:2dd8 with SMTP id f15-20020adff44f000000b0034502232dd8mr12125920wrp.23.1713361736358; Wed, 17 Apr 2024 06:48:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRK3kLgmLwsLY4GbmtvBh8XoNvsy2FL89hzDq2uZ5MoI60b44IFXjgzYSU8HSSDVlc9t1cYA== X-Received: by 2002:adf:f44f:0:b0:345:223:2dd8 with SMTP id f15-20020adff44f000000b0034502232dd8mr12125903wrp.23.1713361735710; Wed, 17 Apr 2024 06:48:55 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id q25-20020a056000137900b003455d32e944sm17439346wrz.96.2024.04.17.06.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 06:48:55 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Small cleanups in gdb/record*.c code In-Reply-To: <87mspt1b1y.fsf@tromey.com> References: <87mspt1b1y.fsf@tromey.com> Date: Wed, 17 Apr 2024 14:48:54 +0100 Message-ID: <87mspsgkvt.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Series of trivial cleanups in the gdb/record*.c code. The first two > Andrew> should have no user visible effects. > > Andrew> The third does add a new error case, so I guess a user might hit that, > Andrew> this is all explained in the commit message. > > I read through these and they seem fine to me. > It would be good to address Keith's comments about the error message, > but aside from that -- > Approved-By: Tom Tromey I addresses Keith's comment, and pushed this series. Thanks, Andrew