From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id C4B243858D35 for ; Tue, 16 Apr 2024 17:18:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4B243858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4B243858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287886; cv=none; b=mJDiZfIhXQLfSxaX+F3x3T8EohMSJittzLd1HufmmF4TRMuRQNe1juMOWhemHDObq5c5wFPETqr9sPKUDpn2tVatBjrjaPJ2O3OOIBPr/BSyFfjK7ZV6MNynXuP7jUhETPRq1FbkUyZK/h0XDonjk4IXRorfew/aCq1SDR5sKto= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713287886; c=relaxed/simple; bh=J/NV7PwOmk+kr0rbHkNGGf/oIQmSKdLlku917VNRcCM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bYW0GAf8QzCmI6iYBWtq28pA5I5v5fOBOmcNI3qUoGMxqvTQ87jZCoqdyaGfgIPzTin1aP+mCNABhxhixC9e9pmvPyBuxCSN9fJJgZWL15AnLH0poTHjjhDf6hUSblrr0gD1qeoICLnHoVwshGSJ2BSHrbBzO+0G2jXZL/y32LY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id wOxJrQcucPM1hwmRXrAMpj; Tue, 16 Apr 2024 17:18:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wmRWr27e7YakKwmRXrFHgE; Tue, 16 Apr 2024 17:18:03 +0000 X-Authority-Analysis: v=2.4 cv=a4T79lSF c=1 sm=1 tr=0 ts=661eb2cb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=5n5VJRrpuRsKQYAUIIgA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Aq9U4g8eTaKv7lT/HDOFvLorT6qvMT9CuegQFYbtx9I=; b=fQn0n/bUdPcsH2vAjqDlmJIeHk M0LOy+V5NoL2UazPo2V7zh9pYG3tuynpB1I8wL5sqnOdGev442fXxMqRUUtCcPyXBI5EV8am1Mal/ Nf23lcfNKkbUTWC2C8x4X4jJp; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:56726 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwmRW-002nrj-1A; Tue, 16 Apr 2024 11:18:02 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Small cleanups in gdb/record*.c code References: X-Attribution: Tom Date: Tue, 16 Apr 2024 11:18:01 -0600 In-Reply-To: (Andrew Burgess's message of "Mon, 15 Apr 2024 15:19:25 +0100") Message-ID: <87mspt1b1y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwmRW-002nrj-1A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:56726 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKi2IgVxffn8YOC/Wg9eJoDzwyTPIKB+UCDYjB7Ly6jDi629mEBNBDqzjj23Bi6R9lzb+d/LKI24+GIEMNJg1xm7iOZU4K+9prEtfu9zogGJjNoljF+V UFcFLfeVxbQnt9XI6fsYOOFKv9GSUtRxFTfgfxD8VjwO+XC1JYFu7pYMOPPFAcp3QI6yD2Njp7jTkSXMPNm3mKSzTFSayXKH9ag= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> Series of trivial cleanups in the gdb/record*.c code. The first two Andrew> should have no user visible effects. Andrew> The third does add a new error case, so I guess a user might hit that, Andrew> this is all explained in the commit message. I read through these and they seem fine to me. It would be good to address Keith's comments about the error message, but aside from that -- Approved-By: Tom Tromey Tom