Re: [PATCH] Fix casting in-memory values of primitive types to const reference

[Tom Tromey <tom@tromey.com>]

>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes> It's currently not possible to cast an in-memory value of a primitive
Hannes> type to const reference:

Thank you for the patch.

I think it is ok.  However I suspect there may be other bugs here.

Approved-By: Tom Tromey <tom@tromey.com>

Hannes> Fixed by ignoring const/volatile/restrict qualifications in
Hannes> value_cast when comparing cast type to original type, so the new
Hannes> value will point to the same location as the original value:

Hannes> -  if (types_deeply_equal (arg2->type (), type))
Hannes> +  if (types_deeply_equal (make_unqualified_type (arg2->type ()),
Hannes> +			  make_unqualified_type (type)))

This code seems slightly weird in that it isn't calling check_typedef.
So, I wonder what happens if typedefs are involved, for example if you
did:

typedef const int ci;

(gdb) print (ci&) Q.id

thanks,
Tom