From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 5E2A63858D28 for ; Fri, 15 Mar 2024 13:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E2A63858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E2A63858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710508583; cv=none; b=t5KI7Znn23FM1bmKLUrAErEEeLDd3RJ9AFbh2NqfBoiuCBtkofk5TcQQIoGCnMPYapcRAH+/twvVyGp90UD5QfN0ecr4nsdGX6DlxXzUhvfCTUiE3dBeAvIilSAhgcjAQL/inKutC68TkQ/sMk5JA4oMaqst+UXQqWJX4EACYng= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710508583; c=relaxed/simple; bh=fxSC3YuWw8y7tB0q10vvs8kK/Wuksu11kKsLhs9F+Ws=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=J/SldQp49lLD436sKYRD5QluSrXPzaXWSB6hwkxgQht1zfTCpBMvzEOC3fZYZ5k48qrk3uxP3OAma4N8rnEd0GdL9x0hdiM7T6ZMtq3PYvGJ3XGKGTHhczGeXvsX/UZLwPqQCKjIDpOZb6mnKqOpdVuPbZALQ910KjT6DAz4OP4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id l6PhrUDGWHXmAl7Q3rqEsu; Fri, 15 Mar 2024 13:16:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id l7Q2rPX0rugjOl7Q2regln; Fri, 15 Mar 2024 13:16:19 +0000 X-Authority-Analysis: v=2.4 cv=V6l70/ni c=1 sm=1 tr=0 ts=65f44a23 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=XAx9KMD4cwjaXahEowkA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XIBnoqvqJrwtdwViJLEzV+i8NsEzjZ8Ihp0pWlx7EfU=; b=rCY2UW6pGsplT4cKHrSBuq5JiK 5hiLq+I2hoLQwcRjetrtNXTOs5d5chKyz7p1eN5qlioiC7V9qpP9GodhC6wzB7t5XK4ZC2ifj9Ai/ Sw0KkZvuqHYAsl8MtRzTaq9Wo; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:35932 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rl7Q2-0033XB-0W; Fri, 15 Mar 2024 07:16:18 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: test exception case for gdb.solib_name References: <856ee4315d2d615388efe8352b29379feefa4054.1710503245.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 15 Mar 2024 07:16:15 -0600 In-Reply-To: <856ee4315d2d615388efe8352b29379feefa4054.1710503245.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 15 Mar 2024 11:47:45 +0000") Message-ID: <87msqzk540.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rl7Q2-0033XB-0W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:35932 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNRwZ+ASE40IG3gmkDAtJwUJydu0YOARIOkIgtQsalYFd5zKnyQ7MnqRqOPMGlaaIDdH109Gy9dNGs4ydkZ6W/7yHNPmNdsahqXm6yanJHcs0d4oAoOC h7FYaQ/D5bPr5pM8VHPexyoLTGefAJ09IvUxPFJUD6Dg/ntLqoO//9h38MthuIBJjLQfNnhxwYJ/qlM43ukii+lEQq2veIVEq44= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> I noticed that gdb.solib_name() and Progspace.solib_name() were not Andrew> documented as being able to throw an exception, but in some cases it Andrew> is possible to get an exception from these functions. An exception Andrew> can occur when the address argument can't be converted to an unsigned Andrew> integer. Andrew> This commit extends the documentation to mention the exception case, Andrew> and I've added a couple of tests to cover this case. Maybe the Basic Python node should have a note explaining that there's a general rule allowing for type errors and the like. Tom