From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 8D0113858CD1 for ; Mon, 11 Mar 2024 20:32:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D0113858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D0113858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710189180; cv=none; b=oeR9EjJnY1+xe4zPrzEd2CoffhvR2MEfIJV15s0IAk307cs6Lc8nas5JusQ5EsrTU7RWSb3CB4/5042zoLYVEUOz56tlcbbvX+DLBmodUL7stZRhL1n7YbVXMU2AisRFneDlHHK1LogX8O9fKXP9TdefqI+3KxVWbhuKzvd8l1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710189180; c=relaxed/simple; bh=iKVtZ8rp98Vf/EsFcYcEVGzcgnISLSzStMKURPV4J3o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YvJVFpLEgl/YcfE6k1djwaK4nCR0KqewxcELDMcPeh+1ChKV/XjI03keaAzBGXOBgxD97HN82S+H6/bpzUGKM/CGNNGj942Wl7QTylsdi81veF26a+OJCkRuBg6CrylwytOkp/cyixxBgj+jHlVd/SOMu3MgxaziYvKP7a6vnL4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-366349042f5so16391095ab.2 for ; Mon, 11 Mar 2024 13:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710189178; x=1710793978; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HuD4nAdXHj/80vABa/cTVyBAvXEHrjkyLE2Ddwvy0Us=; b=WxkYcvSsx/nhwNQgGuA4FUA0PqYq2ZbfP+G7UT+Jk/79+qimAeQG3ev29E0hDYDNwA Uu2lNacWDvaaQ/gorZHNa/NzzpE/jQz6pQ0deP/omcAbCUvWgWghsbGwp+eqpn9e6KhS GrvWVfdd5yjV5DahsrRjdF/O4zXWosZl9//z3BX/kGjF2TN89gYz1Poidc7GZnXDvNmc BQLjS/UH9osntT2WO4mhi29kvpQEZBRKVfyqO67Xn0jD5QJPG95g+4cG+bT8HZJY/crN tB5A3wsD/1x0tWCpLZsDfMTjzCld+gXhaIlxj/sq2qXFRPH1cnOvCss1wPjtFwrfOCtm OdcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710189178; x=1710793978; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HuD4nAdXHj/80vABa/cTVyBAvXEHrjkyLE2Ddwvy0Us=; b=AmPWCYjlPQTdc016mdAy+fTfnAdc9lOVFRGF6458DiUdvuSa/wb1PH3oXLE4OskXbY 109O8hkD/iFNblQ3UNefTiuqL1tNTSGgFAwinwkj9N74PvbOFTycidz1Gn+IKh0WieXA ZMqSoWD8VdWTuCKR27oXtTWpwfv/ALX9896IidQ2hO0Xt/4vIAxlXNDmZ6U+KV02ESPw fJAdV72kHIIki8aJh9CUj0qmVs7d9w1NzP1b3gm2VWT2Uhuem6UVnU0BgpqnOPVhFEsz odTj6T0WHnclAKwmoNqoGxpUsbMHSN0BE4wJSzj2tZPICO5PVldRv897Mghwol4x1GFt RZDg== X-Gm-Message-State: AOJu0YyToy9Rk5PsYXDLka1U4KSt9XHSG1KeJff1/HmF3NilZSs0bkow Qhveify5DCJvYMfCAo2Tv24/kTfvFORiNJhzCgZ1mYB+ALrnUGM9nW3LD4psQw== X-Google-Smtp-Source: AGHT+IETwgPFler7ol559yBeni7s6MTCcjd3Dva7NM/Zvgd0NSja/9/Iwy7N3sQkZC9EAvrhWEh4GA== X-Received: by 2002:a92:ca05:0:b0:365:1044:4dcd with SMTP id j5-20020a92ca05000000b0036510444dcdmr10398992ils.16.1710189177845; Mon, 11 Mar 2024 13:32:57 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id z9-20020a92da09000000b003642dacafa5sm1921419ilm.29.2024.03.11.13.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 13:32:57 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Special case NULL pointers in dynamic type resolution References: <20240213193203.2239399-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 11 Mar 2024 14:32:56 -0600 In-Reply-To: <20240213193203.2239399-1-tromey@adacore.com> (Tom Tromey's message of "Tue, 13 Feb 2024 12:32:03 -0700") Message-ID: <87msr4o6fb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> commit f18fc7e5 ("gdb, types: Resolve pointer types dynamically") Tom> caused a regression on a test case in the AdaCore internal test suite. Tom> The issue here is that gdb would try to resolve the type of a dynamic Tom> pointer that happened to be NULL. In this case, the "Location address Tom> is not set." error would end up being thrown from the DWARF expression Tom> evaluator. Tom> I think it makes more sense to special-case NULL pointers and not try Tom> to resolve their target type, as that type can't really be accessed Tom> anyway. Tom> This patch implements this idea, and also adds the missing Ada test Tom> case. I'm checking this in. Tom