From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 9982638582B1 for ; Tue, 13 Feb 2024 16:51:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9982638582B1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9982638582B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707843090; cv=none; b=LVSvUFvojq+mc1UIxR4Lj3OIKRAiQw1EL/qjZwq2fO5faxrVrcY9fi9rM3287EA7m/hCRbIeAuI85i1D2zAzXR+ESW/Zdw2K+IU7hkWrCtYk6BEOLjBa7eoQOq6GhawRcOIGGTHqhPmhxf7Jr51F+yAGMw2Qfxv6OxHiIGUdz70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707843090; c=relaxed/simple; bh=kEY+KcvuUZyHofKQBAnDAPUpXeBB0nJo+01zZJcrHWE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=g539O/rvqIDQg79b+ikg9mvu6aWxjuklTUvsPSxtAw1Kyydi8HTDcA6G67OXrDtiOBkLohW/QMUmiYEhgzTvAhHNl1jEJlPRoBWXXAqjcEucYoTZtto5qEuby1izJC/k1yWsTLNvobzbs70yuXaMnSSWYtIIkyrrG+5BP0/K1JY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7ba9f1cfe94so174887139f.1 for ; Tue, 13 Feb 2024 08:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1707843088; x=1708447888; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hJ1kv7gXB4T4iHhb/O1KyIfxNmiiuzLfj8CDpjbf3qM=; b=bGPn8P+cT8ZxnSxrSdWo9gcwVTBbcUR/ZO2htDxIQhmlDo8sre+4smBOS/EbRapceH P0tGmFVUkzIKfSrX9tCnZyWjg6Mw74Q78MVNKoYooOVvnjNdukLNgIqS7aaQjmVdeXRU TMbeSORP/1kU1h152CovK2J09onE8dMTVnVFf3L55aMDlwAWMsG7JaqPVWMOroJY6rRj Iq2cGglKvnnAbFexITYIZqAmu9OY01WeLaYPs9gSnPbK6Ua9staxIi80HUhMAN2U+KWj 3kxu97VoFi1sdok1APNmE7RaBqkE3lmscej3GfxWKuRSRiWpEwQriBlIDOGlVcaMlVhg gDnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707843088; x=1708447888; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hJ1kv7gXB4T4iHhb/O1KyIfxNmiiuzLfj8CDpjbf3qM=; b=AIktA4n0v1WA7a8h+brFejuTwY10BCY7kmif0k+bOMWSfau9WNL5izAkgq9PiuehO3 0iLxIzjunGIJtZHcArLLF0qm88ey9UN/WIVK0btzrYQfU1zqJHdSIccUeNr0tD7v24vE qL0aXche0YRyEsz1YY2F8gEvgJX70zfCl2EfBkPaAkwzT0NyZn/HJZWPwjl11NV2BN5Z cgiGODHyiUV+oZ3YrR8u/SaMh0Lsu/P4P58TVOYpxeRD8JxclXX7zhjd3LMKNlC1p6+o sKwYA+7qYbpyhp5DtXYViToSUIzriQzqHqXEI+qtmEMLoLtPUtTVRC6DlGkmZRkIHoOP upWQ== X-Forwarded-Encrypted: i=1; AJvYcCW7fWf2/4u6oSeCBNhy/SDXbdryQmFcD3Iu5ZTxhGfxUBF+BEYMZvESHQFSWVu1AjNVJulRGcshillr/OEes9HCgDVT9CwRSmz3zQ== X-Gm-Message-State: AOJu0YxDh5Vf2Oy7ykI0I0j633E0LmtxnGnRqRrz8c7K2ly5X5xgqUrY 5K5kpUbmaxYg4d9HqcPJLKwNBdfvsif0PlZAC0ZkvtLxHAA/HVGqJBP+78xXPQ== X-Google-Smtp-Source: AGHT+IFZgxGGUrYbbo3hjrxcEQgUUBErTyFGPUmOuu+Kf7CGTtcpKAI8MyngnbpC/+DzgQasfaEwOQ== X-Received: by 2002:a05:6e02:12c3:b0:363:9f5e:c449 with SMTP id i3-20020a056e0212c300b003639f5ec449mr2228716ilm.1.1707843087698; Tue, 13 Feb 2024 08:51:27 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWYE+dWmtDKhyDYBkoDRiDuwZNHY0NvagQYuBWPE11EiTWTpPry9UUX4UldhZK1lv+a2sEK3AEb1CDjJR1IYH9BoIzj9UHDCDUx8g== Received: from murgatroyd (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id y2-20020a05663824c200b0047333f454c0sm1986325jat.76.2024.02.13.08.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 08:51:27 -0800 (PST) From: Tom Tromey To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add return value to DAP scope References: <20240212-dap-finish-v1-0-8e30870e8b25@adacore.com> <20240212-dap-finish-v1-2-8e30870e8b25@adacore.com> <87o7cke7d8.fsf@adacore.com> X-Attribution: Tom Date: Tue, 13 Feb 2024 09:51:24 -0700 In-Reply-To: <87o7cke7d8.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Tue, 13 Feb 2024 16:01:07 +0100") Message-ID: <87mss45mur.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "K=C3=A9vin" =3D=3D K=C3=A9vin Le Gouguec wri= tes: >> + def fetch_one_child(self, idx): >> + global _last_return_value >> + if _last_return_value is not None: >> + if idx =3D=3D 0: >> + return ("(return)", _last_return_value) >> + idx =3D idx - 1 >> + return super().fetch_one_child(idx) K=C3=A9vin> If scopes are cleared whenever the inferior is resumed (my para= phrasing K=C3=A9vin> of =C2=A7 Lifetime of Objects References), can this method be c= alled after K=C3=A9vin> _last_return_value has been reset to None? K=C3=A9vin> Wondering if the outer 'if' is necessary, since we only create a K=C3=A9vin> _FinishScopeReference when _last_return_value is not None: Ah yeah -- that 'if' is a leftover from an earlier iteration. Thanks. K=C3=A9vin> Tangentially, wondering if capturing _last_return_value as a K=C3=A9vin> _FinishScopeReference.__init__ parameter would make sense. It doesn't really matter, because all these objects are only valid during a single stop. Tom