From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CBFD43858CD1 for ; Fri, 12 Jan 2024 13:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBFD43858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBFD43858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705067073; cv=none; b=I7wpnE1nrVldCYVh8Z8JsHxTptUpJyQZ8c8PExEL8hyYe6gNXcJSBI9kBTps9Ts/MFov73+IvwE7QW+RpGBjw00n18tQjF8ZN1KhOaPeVQCJllIl3MBUNI1tVfbfc4sJeAKupNtaa/Ohk40pIq8Ju/uK726TIrUAMuHB/9Krtm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705067073; c=relaxed/simple; bh=Q8kYvZtYU6Kg7K/oApuUAqHOU8JlLnShWUH/TCPCZ8E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=G2d78BswpjBRwx2t/K/+vnEn6HY7mE2U/dzzxmLGa/LEI8Ar4F/S1S7TwWeCeqN8QvhY+JTxa1q+/PHmdmOAYRek+kz+ZPgqgnHXM/1YrFiJZe+J4jMy8bqUmhccEVY6emRDrrQfCJgS/CVzBI299+ztGT46wGpK8R3fuSpE6TA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705067070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9YZwN2Un9oW9ab8ztHNFQVM9fdq92I8c2kOXmFG3VwM=; b=O30Nd8YRzbvD/ikm1cldM3Bp+KcyBQCAFjz7sw+pviJVRPBk5gGaoyRhzTXTRIAs7lNxzi el/E/mHhGxd9iu2+X6542XcyNEQBgVJQa4ioCQHiQ92Rj40PZlqVZ/9as+7zjSttgoomNd peSj395z/Ty2L05dNXejskpnNhHSY7g= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-FiSujuz6OaSaWgB9Cx5Qug-1; Fri, 12 Jan 2024 08:44:29 -0500 X-MC-Unique: FiSujuz6OaSaWgB9Cx5Qug-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a28f6a78b83so406539866b.1 for ; Fri, 12 Jan 2024 05:44:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705067068; x=1705671868; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9YZwN2Un9oW9ab8ztHNFQVM9fdq92I8c2kOXmFG3VwM=; b=DHhDKLAfeyVIuaZGE9mll3INIqK3wS5vQx6go6DcvLfgy2tT0snfCipzxVu35x/h3O pyxltMgc3E0NrTkaZgM+90GZQh7/kYm5SWJlFskpKVlRPnRsioC3eezaR+aq6G9fq0/i du8U2Hr4Om6vhP5mgBgy0z2Y/QdLjzH/F+h3om7+C1bPmk/6YQMn6CIaakuQKtV3OXW0 GyATA+X7NWyTEtTcttC1nQUMMBS4/836a1th0pXSbNzi/9HsoPqo5TvojlAhwEXBiL3s SLW1LTc/Mzr6HQdgbFnGwRmdAJatQqxUq+TFoYRVOIijNhraZMOSlFptr0bf0mhgg9KZ QW9Q== X-Gm-Message-State: AOJu0Yxo8qC4kWoEMzfqGoMUpW9szoiCmmUGiByBAeUbnU/pHzODnXvw 5tZvrTigRlUUyHSkDMDwucsmHHQVIsK1iNPfs332R6UJwLSSLrxJoxW5dVbEJ/kgbBJFOJm2x4Z SW71bQym4IsBj5Zp9xmshDVDJSzPVP3bWkOMpMw== X-Received: by 2002:a17:907:c08d:b0:a28:feaf:ea75 with SMTP id st13-20020a170907c08d00b00a28feafea75mr965285ejc.20.1705067067837; Fri, 12 Jan 2024 05:44:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmu9stDEozEf5O75yyGBDyFqbySz7DbTepaiNCRolBbT20DbJxDtoq6a3EsxYZqohZ3EYsJg== X-Received: by 2002:a17:907:c08d:b0:a28:feaf:ea75 with SMTP id st13-20020a170907c08d00b00a28feafea75mr965252ejc.20.1705067066136; Fri, 12 Jan 2024 05:44:26 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id xo16-20020a170907bb9000b00a26aa5c5a60sm1841442ejc.19.2024.01.12.05.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 05:44:25 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/8] Python __repr__() methods and new __dict__ attributes In-Reply-To: <87mstdrrgw.fsf@tromey.com> References: <87mstdrrgw.fsf@tromey.com> Date: Fri, 12 Jan 2024 13:44:24 +0000 Message-ID: <87msta7jk7.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> In V2: > Andrew> - Fixed problems in thpy_dealloc that Tom pointed out, > > Andrew> - Used @group...@end group in the docs as suggested by Eli, > > Andrew> - Added patches #7 and #8, which are both docs only patches. The > Andrew> first adds advice for naming attributes as Tom suggested, the > Andrew> second is just some doc updates that I noticed in passing. > > Thanks, this looks good & addresses my comments. > Approved-By: Tom Tromey Pushed. Thanks, Andrew