Re: [PATCH 1/4 v7] gdb: Buffer output streams during events that might download debuginfo

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello,

Nice feature! Just a few small nits:

Aaron Merey <amerey@redhat.com> writes:

> +buffered_streams::buffered_streams (buffer_group *group, ui_out *uiout)
> +    : m_buffered_stdout (group, gdb_stdout),
> +      m_buffered_stderr (group, gdb_stderr),
> +      m_buffered_stdlog (group, gdb_stdlog),
> +      m_buffered_stdtarg (group, gdb_stdtarg),
> +      m_buffered_stdtargerr (group, gdb_stdtargerr),
> +      m_uiout (uiout)
> +  {

This curly brace should be at column 0. Which naturally affects the
indentation of the whole method.

> +    gdb_stdout = &m_buffered_stdout;
> +    gdb_stderr = &m_buffered_stderr;
> +    gdb_stdlog = &m_buffered_stdlog;
> +    gdb_stdtarg = &m_buffered_stdtarg;
> +    gdb_stdtargerr = &m_buffered_stdtargerr;
> +
> +    ui_file *stream = current_uiout->current_stream ();
> +    if (stream != nullptr)
> +      {
> +	m_buffered_current_uiout.emplace (group, stream);
> +	current_uiout->redirect (&(*m_buffered_current_uiout));
> +      }
> +
> +    stream = m_uiout->current_stream ();
> +    if (stream != nullptr && current_uiout != m_uiout)
> +      {
> +	m_buffered_uiout.emplace (group, stream);
> +	m_uiout->redirect (&(*m_buffered_uiout));
> +      }
> +
> +    m_buffers_in_place = true;
> +  };

There's a stray semicolon here.

> +
> +/* See ui-out.h.  */
> +
> +void
> +buffered_streams::remove_buffers ()
> +  {

This curly brace should be at column 0.

> +    if (!m_buffers_in_place)
> +      return;
> +
> +    m_buffers_in_place = false;
> +
> +    gdb_stdout = m_buffered_stdout.stream ();
> +    gdb_stderr = m_buffered_stderr.stream ();
> +    gdb_stdlog = m_buffered_stdlog.stream ();
> +    gdb_stdtarg = m_buffered_stdtarg.stream ();
> +    gdb_stdtargerr = m_buffered_stdtargerr.stream ();
> +
> +    if (m_buffered_current_uiout.has_value ())
> +      current_uiout->redirect (nullptr);
> +
> +    if (m_buffered_uiout.has_value ())
> +      m_uiout->redirect (nullptr);
> +  }
> +
> +buffer_group::buffer_group (ui_out *uiout)
> +  : m_buffered_streams (new buffered_streams (this, uiout))
> +{ /* Nothing.  */ }
> +
> +buffer_group::~buffer_group ()
> +{ /* Nothing.  */ }

If the destructor does nothing, can it be removed?

-- 
Thiago