From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 1E5993858D33 for ; Fri, 22 Dec 2023 15:26:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E5993858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E5993858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703258774; cv=none; b=SwkkPJIt3LeOTF8+gnsc0y+739PukJ4hwBPgcBpQ1PGCZuROdH//TLvjiTzdHNKm/xm96AYuH1uHGafmvNt3wI3CldR+g4Dg5S5zMkgDN0eLSrJ2uWjisxE7zDCGtAs6Lz2bGGU3iT6OkWQ9hH7HxfVEc9A2tLSlg1VBgTekDcY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703258774; c=relaxed/simple; bh=U2dZowFgGwMcvP0IERmYPowHI1fvBigdaUIsSxi/1oM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AkV1XJLcTFqngRAkcJ5pGzlxL0p8xtLC4y369db5hoIail9eefkH8s+bMIlX/HM/W+MhCqTOReLapHBmmELZNMxEFdmAo5CxDssuM9ErmTK7foHOxrtrCw12IzxbmcPO+qQGH+8uxVYgCoUF891El6wRJ0GX/Kkw2U1JKtlSIOY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id Gdbur0IPX8HteGhPfrsNlo; Fri, 22 Dec 2023 15:26:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id GhPerV0LhRGmSGhPerPZD8; Fri, 22 Dec 2023 15:26:11 +0000 X-Authority-Analysis: v=2.4 cv=efcuwpIH c=1 sm=1 tr=0 ts=6585aa93 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=7mOBRU54AAAA:8 a=YLy-y7qZAmf6Y9Ms70AA:9 a=wa9RWnbW_A1YIeRBVszw:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eNECBOz/SuRHpVF5+AhDR51Rtyd8tzV/56hlYMsu3bw=; b=WERXB6TsdQUm4idyk4ZunmHWGY na1TgsfNwBIq9EStRznbOFiHxzyoHlmx5RX7WJopK3q9KSraJZGuJjEcDfQkbE7KknzoMZPO9ZIXO wQrIKWSRLdkI9afmN1NMbDa7/; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:56270 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rGhPe-002Ok9-19; Fri, 22 Dec 2023 08:26:10 -0700 From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 15/15] sim: warnings: enable -Wshadow=local References: <20231222012355.7504-1-vapier@gentoo.org> <20231222012355.7504-15-vapier@gentoo.org> X-Attribution: Tom Date: Fri, 22 Dec 2023 08:26:09 -0700 In-Reply-To: <20231222012355.7504-15-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 21 Dec 2023 20:23:55 -0500") Message-ID: <87msu22r8u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rGhPe-002Ok9-19 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:56270 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfELym+h7FH/5F7BN42P/lvJML2KUX1iIJjEWfLW3Y90QxLHcwjRLJlk0QFfyThKgZqwLQYybx+KmkjUcTMdBGOUwmG/PxtsJ4zJb5HRMYMlUmEfyR03p 3WZ2PhvocoQwIKSqtMm4AMNf4fwSzMZn+DqMKB1nXPk5zE5hVdDq8Es7/1ni+GveWLQ+3dc4d6vkYajm6QKiJn6pStbrvnpcnXc= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Mike" == Mike Frysinger writes: Mike> This brings us in sync with current set of gdb warnings (for C). FWIW I skimmed this series and it all looked reasonable to me. I think it's worth applying. IIRC in gdb the shadow warning found a few real bugs, so even if it didn't help the sim immediately, it can still be helpful as bug prevention. Tom