From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id B6469385BC23 for ; Wed, 13 Dec 2023 16:36:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6469385BC23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6469385BC23 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702485376; cv=none; b=JegXQHkDRdnKdaS0w7CdTs/cVOQ7FooA0UFnt8Lr4S1vzFHS41ZRX7QQQP5DogjaM4KQ6kXXqDq+r3PTjdxKbUOdxtTz0msfPRRCAq/qAVSr0hruVTiFPxPbVRbmWqStzAGTDWbJwDJY5qOOeKMmj2pgwUKDiZ+R09mInyVAWwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702485376; c=relaxed/simple; bh=mlwzGKPb1XFoTxo7SQkhG5GjGS0Es0bNa5iSc/i8mgE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nix6BJa8N8BGErfoSkkHbnErc4pPnUcA4TSPqLf3fsXKb5beTPdWNEG6Jopxy6i9RPomP7BHGCWIUqZWMlqRdihu/pQPli3XV++7St/kLwYs1k25bOtRTCRjNs4HCYdyK8TePaeM6K6pvsX+MhNRd1OtTY1RLj2hm+uiEsDJG0M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a1c7b20f895so827569066b.2 for ; Wed, 13 Dec 2023 08:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702485373; x=1703090173; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uu16FXmxW2JAXdmu76yJ2dRFsaxzvHeHPIwIz8LjQP4=; b=AIBSDUEuoVusyiQfyUEJJiqTd9YVoliJzR6rvTjOoVS8Tq0cOTcl+TNsv48+JE2lnj lt3psG6jCthiDIoQiItzDD31KYzOlgWM9ww1KJfKZlk7Tyoqsg9HUnWSu9JUjFTKhvkM eU5Cz185xH28lHBqNwi/xl7Hz0wmm5DrD1lPg36ntr7AsTqATYCV67qChYD525RI4Tmj kRp6TzzN/bSiMR5GYI5lotaLtN6RYJT60Zho6KU2rbvODsIWqmMHZOkBUsbtiZBhDuO+ fvcm8yLCk0SzoWaq2geC9yiLQJa5twNdFvJ5v2VneOnAU9/xJSoxBFSyJ5g1S+B4UZbj Cw9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485373; x=1703090173; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uu16FXmxW2JAXdmu76yJ2dRFsaxzvHeHPIwIz8LjQP4=; b=uqaDEo3EcvLSqOQDbhZulssL3Wj5cCs0zMGJCpNShKp524dBUyxc917L4/2xYPxFe7 qMv6vLb1jUdGEAQmVrS990/0A7EuR004TkvmYMf+MLGqdM1xZAD54A+juUKEqVVY5t+G 0jTrT9mUz98NxhDaZGfXPWe2BTjhksOV7zU7kYZiQP9KXJ4pb+E41yRr1jkHi45zT2GP o8/ocJ2U6PR6QIEyIUkyh41c8mWnWDyDXT90bzAPxRTyWozHcx9rgMNL5v/ScQ8Qsil2 mPxd0YO3zGXjjTs5W8yOrLbiUipfadMprX4rKtkHmU+xwULUNmT5PkX1xtQBpc8iZHge 6y9g== X-Gm-Message-State: AOJu0Yxgu3QSy0zJTwITphlvdTb1Wooy30DNu5WGi1DU77OsCuPQ/x+Z 0mwBsyBAM1Dk+Vpb1b0pDt6nVvDQ7e61rdEjvmMMCg== X-Google-Smtp-Source: AGHT+IHxIe6f9IfKeWGceZz2eAGRN0SHHZecArhE28WF96e+ARnDYrP1OQTp+Osh2Ifwy7697GTc0A== X-Received: by 2002:a17:906:f753:b0:a19:a1ba:8cdf with SMTP id jp19-20020a170906f75300b00a19a1ba8cdfmr3889731ejb.125.1702485373117; Wed, 13 Dec 2023 08:36:13 -0800 (PST) Received: from legouguec-Precision-7550 ([2.57.72.67]) by smtp.gmail.com with ESMTPSA id tf13-20020a1709078d8d00b00a1b8829597fsm7999416ejc.114.2023.12.13.08.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:36:12 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Check for rogue DAP exceptions In-Reply-To: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> (Tom Tromey's message of "Tue, 12 Dec 2023 10:44:41 -0700") References: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> Date: Wed, 13 Dec 2023 17:36:11 +0100 Message-ID: <87msue3vr8.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: > While looking into a question I got about DAP, I found out that the > DAP 'attach' test had some unexpected exceptions in the log file, > caused by an incorrect assumption in the stop event listener. > > This series tries to make the DAP implementation a bit more robust. > After these patches, exceptions that are expected in the normal course > of operation are not logged by default. Then, the test suite is > updated to check that no rogue exceptions are seen. > > --- > Tom Tromey (4): > Introduce and use DAPException > Add DAP log level parameter > Avoid exception from attach in DAP > Check for rogue DAP exceptions in test suite > > gdb/NEWS | 5 ++++ > gdb/doc/gdb.texinfo | 18 ++++++++++++++ > gdb/python/lib/gdb/dap/breakpoint.py | 12 ++++++--- > gdb/python/lib/gdb/dap/evaluate.py | 12 ++++----- > gdb/python/lib/gdb/dap/events.py | 43 ++++++++++++++++++++++++++----= --- > gdb/python/lib/gdb/dap/launch.py | 7 +++--- > gdb/python/lib/gdb/dap/server.py | 10 ++++++++ > gdb/python/lib/gdb/dap/sources.py | 6 ++--- > gdb/python/lib/gdb/dap/startup.py | 47 ++++++++++++++++++++++++++++++= +++--- > gdb/python/lib/gdb/dap/varref.py | 6 ++--- > gdb/testsuite/lib/dap-support.exp | 34 +++++++++++++++++++++++++- > 11 files changed, 167 insertions(+), 33 deletions(-) > --- Left a couple of comments on some of the patches, but the series could go in as-is IMO =F0=9F=91=8C Reviewed-By: K=C3=A9vin Le Gouguec