From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 0C1C23858CDB for ; Fri, 8 Dec 2023 15:57:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C1C23858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C1C23858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702051063; cv=none; b=mj0NkquJkQ82ne8dhf0W68mbRqB23+47CvCUpOJ2z0mkX+SY2uG5O/v8fUXwLVuZ0O0OqGhprCjv8j5DcfMl0Tqn7rmGeQ6H6l/xV4Pw+V3lDyX9+DVs984ANowPJUlT8ZjPagQhdqXNnMU7qg4oL90CMyTJ+TYh6WuMQvdK564= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702051063; c=relaxed/simple; bh=bmtqYcR9sehUISKbo7+huRXsH6VdyuA9dOqr1B6q3ig=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=S0leAn5nSjRi+9VGx98OugwBzP+K5OEnuR7NxVJ3sstwS3RmF2UfVOA7oT5xnS2+rrs/OutTPGkRMGJdz2Lg3zx1LxIBKzPhmJ3FWbuQg0YO/6W+rsc/SLriKqSEwvGpTFaOAsTEPFQ5iGn2qrDvFeglX/+1hRjVIiA0ronmmc8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id BYaSrJjyCWcCIBdESrEiVl; Fri, 08 Dec 2023 15:57:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BdERroZSzAKScBdESr9UAx; Fri, 08 Dec 2023 15:57:40 +0000 X-Authority-Analysis: v=2.4 cv=N6w6qkxB c=1 sm=1 tr=0 ts=65733cf4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=2zNqHC1aFkSI_XnKzEkA:9 a=zgiPjhLxNE0A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7MedpTWXJOoDUvQXt15w1qSDt22QiMpHGZbUP7L7o/g=; b=nJZUya8GgQA4kLDY3w1S5Zf+B1 sEVVSZZ2vKlHzY4/wkVDFvnETNph9mWOus7/QmyvHk18K7EU8RxRFUxQ93NKP3LCA4uFNXUVr7P3a WHeUinr8/SlUsv3QcJCJZFqqI; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:59482 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rBdER-0010mX-1q; Fri, 08 Dec 2023 08:57:39 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Handle shared border in fixed-sized layout References: <20231110165419.16793-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 08 Dec 2023 08:57:38 -0700 In-Reply-To: <20231110165419.16793-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 10 Nov 2023 17:54:19 +0100") Message-ID: <87msukhekt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rBdER-0010mX-1q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:59482 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIYb5t9iVQUdRRlPxH50YMhx0jHucxzeEjLkmHCEBrx1m93dmB9tA+tfTTtXBZA+Ppb//l8SRU8ASrYMI2ATwwJEcmRacFS2mnMrP54rDlIKDD99+U6C nLXIm5p4h8fFxdUJ7HQ6LyZOYtMAaeyA4clNF4YHW+F9CNro0TGEVO8YMVjUzbTdbZfDoSHrtqpNVjFT5cg9GVJ/PTu3xP8vcVI= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> In tui_layout_split::apply I noticed that for variable-size layouts we take Tom> share_box into account by decreasing used_size: Tom> ... Tom> used_size += info[i].size; Tom> if (info[i].share_box) Tom> --used_size; Tom> ... Tom> but not for fixed-size layouts: Tom> ... Tom> if (info[i].min_size == info[i].max_size) Tom> available_size -= info[i].min_size; Tom> ... Tom> Fix this by increasing available_size for fixed-size layouts with shared box. This looks good to me. Is there any window with a fixed size other than the status line? I wouldn't expect this to be hit currently. Approved-By: Tom Tromey Tom