From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 6C0923858D37 for ; Mon, 13 Nov 2023 17:41:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C0923858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6C0923858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699897296; cv=none; b=j4IdnXPMaPAWiqX0lf/ujLlD8TaXKnk6s9eK1vf9Zhi5450CLPwiWxasPO7XkeuZ+ENxz/wUi0SUivUOCExnP//29+8IHXwDh/GK/6YtGyx597G0mmIrg1StF4bMjOmVW/kfrhL8ecibfl6lJCEH2gkpGLImiYRPB34gMz6sdkk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699897296; c=relaxed/simple; bh=BQ8m83IxeVt/ufjXw4j7AwqLmksJ+HBUPqzytqKxi2Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nW+LA9zUV5BiizGh/obmj5j8LcPcBA3mLF6PSoDALro5awIIrm79C0YJYC+pALsgWdwPXU0ZntIrsYrW8w6jYaM9GgFWCI9FnPiDCl6ySZ020PX0WU64p+031iczu97vL5C4tIX7R5ywxzOzdKAr+i9LKAPC45s0GyM2vP5YEuI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id 2a9JrsZGK8Hte2awIrE9gf; Mon, 13 Nov 2023 17:41:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 2awHr5SyaAKSc2awHrIfpl; Mon, 13 Nov 2023 17:41:34 +0000 X-Authority-Analysis: v=2.4 cv=N6w6qkxB c=1 sm=1 tr=0 ts=65525fce a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=cBTMsmLo_K0hd5VfFdAA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wuP9m4O+H4/eFrO2hONPddrwew9ICeeK0PjOHr3qvgs=; b=r4yqj0deAqZ0cxaQxl3VsT4PLK D/5YFKnDSZyE300tGrht//PIkdx3MwYWmW89G8S+/6g2voyG6HnYv0tSo/do6lmVx4lB1ZkcTER3d PvWPQ0pqxEU4Y7UFSRmIYroav; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:52262 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r2awH-002b3G-1E; Mon, 13 Nov 2023 10:41:33 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] [gdb/tui] Refactor prefresh call in tui_source_window_base::refresh_window References: <20231110130051.21239-1-tdevries@suse.de> X-Attribution: Tom Date: Mon, 13 Nov 2023 10:41:32 -0700 In-Reply-To: <20231110130051.21239-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 10 Nov 2023 14:00:49 +0100") Message-ID: <87msvhsg8j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r2awH-002b3G-1E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:52262 X-Source-Auth: tom+tromey.com X-Email-Count: 19 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHEz/MRfrUxMXuDa6Sfy0pqPNipACsw+ckUsakL9yZlv3GHRPnaj65itB68KSsSpEyQEavgmrN3GuotUM2erdayCXhxwAp8RYuxqPLy9cl2yb+cef7Kz 4Af7TqHdKHuf21QsgVhZ0Kds2aHelpoyWVbEoth0MjanoC5g0bZredvNJl3jQ2U8QLVj+ZmTeL6QsI922lKwR54dZ0uNBPzyHpk= X-Spam-Status: No, score=-3018.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Currently the call to prefresh in tui_source_window_base::refresh_window looks Tom> like: Tom> ... Tom> prefresh (m_pad.get (), 0, pad_x, y + 1, x + left_margin, Tom> y + m_content.size (), x + left_margin + view_width - 1); Tom> ... Tom> This is hard to parse. It's not obvious what the arguments mean, and there's Tom> repetition in the argument calculation. Thanks for the cleanup. Approved-By: Tom Tromey Tom