From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id A301B3858C20 for ; Thu, 14 Sep 2023 16:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A301B3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-79545e141c7so30980539f.0 for ; Thu, 14 Sep 2023 09:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694707410; x=1695312210; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AwTaFWDFhoAd3XQwsCnV8WNS/DFbLnasH3Jgq+rAgPI=; b=XKWZdpUwLKYmV/4XEuM8gv3lNf+WM8SNIUalEdpvoJ2c39L09SFeLjO/+0l2xyDNx8 K7pSvAlRSdcTTZyKOQPud93fDY5zD5EICK/g+upyUXMkr7CwGBwpSY5YO7S155kfpFbb FgebdnxqzKg2qi0W3Qdz6akLftUiCQNSIpPjDxR7yMjV+03hwmYqFWmXxmNMfqgmoSyf x/IN0iHwSiUWWbquQGW2gv8J9uSGqil98VPoNlVqYJkrkIpk4AvoYSyDV3M9Jmo7smw1 Hr1NY8zVDAN2nJQ/lTreqQ8EuaDqiEMW2YaKHmRO/wi/XOq770mlzZ6qKSv1kAPM/jJE 76sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694707410; x=1695312210; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AwTaFWDFhoAd3XQwsCnV8WNS/DFbLnasH3Jgq+rAgPI=; b=dbrfHESIJYwbMtIG+f7CbL3KSKfYcfeQ7qMzx90Iu3fZ0xBTyx5CzObYpwiZZFyzrS rDNmlImTKojHFfbEudsSR+Pr4/wpfzKZC+6QuJwcqoJ1W0217j5/xeWbQoGnzah4wFh8 gHIfq0PZ1YyHanBCGzuDEZZF7dDvcFDcCKbqYVAAxUlxtdPItE87M0prYrHj9z2B2f4g l//fYLjCvZspsa/Ny9ZaB6Lf/B2RRWsbnaEIVre4YAvej7H40oyEZORX5dm+Wd/JUYVF MMpnR6WOXcEfnwNxLpMfXDpQDO7u3e3Pm4SRrC4smgWLhWarGwCD8wJ8qvMr3oiPGYql h7Mg== X-Gm-Message-State: AOJu0YybfiaOU2wlqUsn4Rm8ORLHtJxRtdkEIb+ziDhaMk7h82HRSc+O TkMR5qrhTij+m0EVEFbY5UDYpg== X-Google-Smtp-Source: AGHT+IFwrC5D5xGXa5uV1S8nSDlN3uKKkMrsOkOSe/TuWXkEpFzjBci7SjvFimd9+XS4g9hOeClgLA== X-Received: by 2002:a6b:3bc9:0:b0:783:42bc:cc5f with SMTP id i192-20020a6b3bc9000000b0078342bccc5fmr1851992ioa.8.1694707409904; Thu, 14 Sep 2023 09:03:29 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id j5-20020a02cb05000000b0042b61a5087csm477018jap.132.2023.09.14.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 09:03:29 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] gdb: fix buffer overflow in DWARF reader References: <281fdfc6ef3997cfab17d2379b51b208c0e00070.1694706424.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 14 Sep 2023 10:03:28 -0600 In-Reply-To: <281fdfc6ef3997cfab17d2379b51b208c0e00070.1694706424.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 14 Sep 2023 16:48:09 +0100") Message-ID: <87msxohhdb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> In this commit: Andrew> commit 48ac197b0c209ccf1f2de9704eb6cdf7c5c73a8e Andrew> Date: Fri Nov 19 10:12:44 2021 -0700 Andrew> Handle multiple addresses in call_site_target Andrew> a buffer overflow bug was introduced when the following code was Andrew> added: Sorry about that. Andrew> I'm not sure how to create a test for this problem, this issue cropped Andrew> up when debugging a particular i686 built binary, which just happened Andrew> to trigger a glibc assertion (likely due to random memory corruption), Andrew> debugging the same binary built for x86-64 appeared to work just fine. The best thing would be if we had valgrind annotations for obstack. Then valgrind or perhaps ASAN would catch this kind of bug. Approved-By: Tom Tromey Tom