From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy4-pub.mail.unifiedlayer.com (qproxy4-pub.mail.unifiedlayer.com [66.147.248.250]) by sourceware.org (Postfix) with ESMTPS id 7C1633857019 for ; Mon, 14 Aug 2023 16:08:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C1633857019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by qproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id B968D8025DE7 for ; Mon, 14 Aug 2023 16:08:26 +0000 (UTC) Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id AB5B7100471BC for ; Mon, 14 Aug 2023 16:07:56 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Va6mqXhuTB2f0Va6mqYYI4; Mon, 14 Aug 2023 16:07:56 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=E+cIGYRl c=1 sm=1 tr=0 ts=64da515c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bvlt6mB93sbmEP1ijCzAvsvPdI3x1DsNdIv/Q9uD1AM=; b=WE6GLNYObPMZGrEcEWb9PiycMV AadFave0gDNMvVi+J0b7li5ITCjqWzVdWJOdk1xroIp9n/IU8r7p3Sq+ed3QRX2UiSRpx0Y+jtZdx +GfIVRb7koAOhybmzAaohNF34; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:35144 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qVa6m-002apT-1D; Mon, 14 Aug 2023 10:07:56 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 3/4] [gdb/build] Fix struct token_and_value odr violation References: <20230814111721.31402-1-tdevries@suse.de> <20230814111721.31402-3-tdevries@suse.de> X-Attribution: Tom Date: Mon, 14 Aug 2023 10:07:55 -0600 In-Reply-To: <20230814111721.31402-3-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 14 Aug 2023 13:17:20 +0200") Message-ID: <87msytzjxg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qVa6m-002apT-1D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:35144 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> When build gdb with -O2 -flto I run into: Tom> ... Tom> gdb/c-exp.y:3003:8: warning: type 'struct token_and_value' violates the C++ \ Tom> One Definition Rule [-Wodr] Tom> struct token_and_value Tom> ^ Tom> gdb/d-exp.y:1310:8: note: a different type is defined in another translation \ Tom> unit Tom> struct token_and_value Tom> ^ Tom> ... Tom> Fix this by renaming to c_token_and_value and d_token_and_value. Thanks. Approved-By: Tom Tromey Tom