From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 20CD83858D32 for ; Thu, 10 Aug 2023 16:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20CD83858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 5999410047F8F for ; Thu, 10 Aug 2023 16:20:48 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id U8P2qFJb5sBigU8P2qXt4s; Thu, 10 Aug 2023 16:20:48 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ub+U9IeN c=1 sm=1 tr=0 ts=64d50e60 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=fxrWIV_MI3ho2kg7tQwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Rk0O87STzm+RY1K56ZxLtE/OyFwhPS50CnWnuCZbi8A=; b=Xm7T8gyS6ZSv+RWoDymxY+Iynn Vif59gAnakt+4VOc0uzEfMkGmXsW4J2NS/eCo1R44irQIA4ODzLLeWI9rBFmTdnmbbi8mjx6jrU+g fEsIlRWPOX9co3P3PArAQp2/1; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:42094 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qU8P1-000qNV-37; Thu, 10 Aug 2023 10:20:48 -0600 From: Tom Tromey To: "Ijaz, Abdul B via Gdb-patches" Cc: Tom Tromey , "Ijaz, Abdul B" , "JiniSusan.George@amd.com" , "eliz@gnu.org" , "blarsen@redhat.com" Subject: Re: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader References: <20230801224744.24433-1-abdul.b.ijaz@intel.com> <20230801224744.24433-2-abdul.b.ijaz@intel.com> <87y1itcin7.fsf@tromey.com> X-Attribution: Tom Date: Thu, 10 Aug 2023 10:20:47 -0600 In-Reply-To: (Abdul B. via Gdb-patches Ijaz's message of "Mon, 7 Aug 2023 14:43:01 +0000") Message-ID: <87msyy3m3k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qU8P1-000qNV-37 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:42094 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Ijaz, Abdul B via Gdb-patches writes: Abdul> + func_type_flags flags; Tom> This should use ENUM_BITFIELD like the other spot in the patch. > This flag may store multiple values together with no return and > trampoline types for a function. That is the reason why it is used > like this here. So value is already bitfield like: Actually I think I misread and thought this was still using a bitfield, which it is not. So I think that bit is fine. Tom