Re: [PATCH v1] gdb/DAP - Add completionsRequest

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

>> Since 'line' isn't used, I think it can just be removed here and also
>> from 'completions' itself, as it is optional anyway.

Simon> Right, I added it to make it look 1-to-1 with the DAP spec, _even
Simon> though_ we don't actually use them in GDB,
Simon> as I find this approach less confusing - if a GDB contributor (or
Simon> user) were to look up the signature, then look at the DAP spec
Simon> and not see the same things. But I'll remove the things that doesn't
Simon> make sense, as it were, in GDB-land in the next patch.

For the DAP side (the @request) this is arguable but also fine.
I personally think it's clearer to only name parameters that are
actually used, but if you want to do it that way, I'll approve it.

On the gdb side (@in_gdb_thread) I think it's better to only accept
things that are actually used.  It's also arguably better here to do any
needed pre-processing in the DAP thread.

thanks,
Tom