From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 83BDC3857705 for ; Mon, 26 Jun 2023 15:02:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83BDC3857705 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-345b155fa0aso1957105ab.1 for ; Mon, 26 Jun 2023 08:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687791745; x=1690383745; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1iqPRvQWFm2t06tCpWpMEBxs9g89baJFP5qU420JjuI=; b=JNtAokK2pMAAmpk3w4H7/zAPMGbhY4c/RY4b0jwLY/6jf64Byj/9DKn7UAvCHhhJ3w Bh8w19btv+naav+zBJqh5SKBBN32MSP4XkA6TIVe8ImYbs7sD7RQTRQ9PisSxfOHWntC WqJe+k34FihTcmJhs2yF4FOi4IkuOhCW2G3OfHI/OPW6OTnyQ1UrIbivLP34/przAk/X aYudMfDRq+i0ZDrQXpMcgcSuc6YmZG7T05e0qG+AeqpILc0YvI+Ibh7ZjcpYDwJs9SOF f5+qozfA0nsk7o8EbHWKUIFkhAuYWejkpuSd+G87Xx5PkE1HsxOSWxiDvn+rwXLEB8o9 iRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687791745; x=1690383745; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1iqPRvQWFm2t06tCpWpMEBxs9g89baJFP5qU420JjuI=; b=VbXrVdh9xoobj4YqoPCxD4IXiFuIM6IF2t37B2MtrAegdwFlApoW9gYtcAKnK/dBIS HEu6FPOE6JnAhXucA8sSj2BHEb5Euiq9VAsY0Lvmyx69vVgXiIAcyvKxehPp06tfq5Q7 nQ3fBtlK+K37HmVIcaDwIcCwqYjDg+7yXkYv/AQJ7+5qiiLi+RKg9Dfe5Omte23j/zS5 HVojYiGG9fPhpSg3TFgYVV7rPvF/Tnq/jg9Sx4CMwcYs0prqY7ZoeBklnVIouT2wDCoC WEpci1RRJf+Ooz09JZUo+U6cv1L/hZq5YBeoVcSROyRs/U21Zz6RxRVaQgEXwUynF1AS tdYA== X-Gm-Message-State: AC+VfDwS2fYYg3pDpY2qFeKKzG2NM49ZDFsy3EW+/+mgdm7i5Tr9e97f 0RUeai+zY0ydwzwzBF85Vdju8Q== X-Google-Smtp-Source: ACHHUZ5knLGaYMefbYpf0Ksc1OLGmG9M0W1IFTm44f99jKA4WFoc7vr9I1AKs6Inb7uVLomKKEPG+w== X-Received: by 2002:a92:c044:0:b0:342:89b4:b8b1 with SMTP id o4-20020a92c044000000b0034289b4b8b1mr21303431ilf.21.1687791745652; Mon, 26 Jun 2023 08:02:25 -0700 (PDT) Received: from murgatroyd (71-211-136-248.hlrn.qwest.net. [71.211.136.248]) by smtp.gmail.com with ESMTPSA id t9-20020a92dc09000000b003457e1daba8sm1783090iln.8.2023.06.26.08.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 08:02:25 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH v2 4/7] Simplify FrameVars References: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> <20230614-dap-frame-decor-v2-4-10628dfa6b60@adacore.com> X-Attribution: Tom Date: Mon, 26 Jun 2023 09:02:24 -0600 In-Reply-To: <20230614-dap-frame-decor-v2-4-10628dfa6b60@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 22 Jun 2023 10:19:30 -0600") Message-ID: <87mt0mxo5b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> FrameVars implements its own variant of Symbol.is_variable and/or Tom> Symbol.is_control. This patch replaces this code. Tom> - # SYM may be a string instead of a symbol in the case of Tom> - # synthetic local arguments or locals. If that is the case, Tom> - # always fetch. Tom> - if isinstance(sym, str): Tom> - return True I noticed that I removed this check. However, looking into it, I think there's no way for this to happen, because FrameVars is only ever instantiated with a real gdb.Frame, and these won't return synthetic locals. Tom