From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [RFC 00/10] More use of unrelocated_addr
Date: Mon, 05 Jun 2023 10:13:07 -0600 [thread overview]
Message-ID: <87mt1dsx9o.fsf@tromey.com> (raw)
In-Reply-To: <20230424162211.682763-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Mon, 24 Apr 2023 10:22:01 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> While working on a different patch, I decided to add more use of
Tom> unrelocated_addr to the DWARF reader. This caught at least one latent
Tom> bug, see patch #10. (I thought there was another one as well, but I
Tom> can't find it now.)
Tom> The main ugliness here is that it adds a lot of casts. Partly (but
Tom> not entirely) this is due to the decision to not use
Tom> DEFINE_OFFSET_TYPE for unrelocated_addr. Maybe it would be better to
Tom> write a custom wrapper class for unrelocated_addr instead.
Tom> I moved unrelocated_addr to gdbsupport, but maybe it would be better
Tom> in defs.h. I'm not sure.
Tom> Regression tested on x86-64 Fedora 36.
Tom> Let me know what you think.
I rebased this and re-regression tested it.
I'm checking it in now.
Tom
prev parent reply other threads:[~2023-06-05 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 16:22 Tom Tromey
2023-04-24 16:22 ` [RFC 01/10] Remove baseaddr parameter from dwarf2_record_block_ranges Tom Tromey
2023-04-24 16:22 ` [RFC 02/10] Minor cleanup in loclist_describe_location Tom Tromey
2023-04-24 16:22 ` [RFC 03/10] Move unrelocated_addr to common-types.h Tom Tromey
2023-04-24 16:22 ` [RFC 04/10] Use unrelocated_addr in the DWARF reader Tom Tromey
2023-04-24 16:22 ` [RFC 05/10] Use unrelocated_addr in dwarf_decode_lines Tom Tromey
2023-04-24 16:22 ` [RFC 06/10] Fix comment in address_class Tom Tromey
2023-04-24 16:22 ` [RFC 07/10] Use "unrelocated" terminology in linetable_entry Tom Tromey
2023-04-24 16:22 ` [RFC 08/10] Constify dwarf2_cie::augmentation Tom Tromey
2023-04-24 16:22 ` [RFC 09/10] Use local "text offset" variable in dwarf2_frame_cache Tom Tromey
2023-04-24 16:22 ` [RFC 10/10] Use unrelocated_addr in dwarf2_fde Tom Tromey
2023-06-05 16:13 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt1dsx9o.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).