From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 8BB423855586 for ; Mon, 5 Jun 2023 16:13:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BB423855586 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-33b204f0ca0so25736625ab.2 for ; Mon, 05 Jun 2023 09:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1685981588; x=1688573588; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6rbcFEeGEyzBcbh6zuGsQenjLOnsX9mxfeOtPHeeFe0=; b=NsFIUp9tT83HjtklLPpXaH3pbPqZqD9RgBj/a0w2OLR11a+DqQAztpIBySMLJbxyya L/wEMSvh3gGitTGvHzhhfqcomVTbqi0riUgv572hpBFmAbBwVJ5xmrguM/96mlFQAmdj MQqH6VChalFjAxP4D2fIv1RRNA5GR4OJVlO+ULJt2sBFlBFUtwd1EZsgZGE6rsXE93el cUVX5jdvv8YvvBb/Ix5EYuvCbtSui46LfmR3vRWcZAjY/sUF+PeXyDU6Ef76Xagag8E5 ZtULCtXJsAKk5CJO+l5id2ADVV5S+ZPVkCvmP233zSCP0F4tOW/gVnWxQ/I7tdeXjfYw qybQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685981588; x=1688573588; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6rbcFEeGEyzBcbh6zuGsQenjLOnsX9mxfeOtPHeeFe0=; b=jScFmSs02HFImqVXdqVeHTdhty+5USVcB859jsBzG++8lAy4SndmLGCOzkDfwzJpDD tq1w1fQ3DpuPL+Yqh/BxYRdS4rAHR4cPfvCPhRn2WY3ePRKTw1S5D4Wt8M9PvtbIc2z+ OSU4yCDzNF+Wp3WNwPBZ1klDiJy0zuekC0d33W0ZCiTscCIqEwC3/rprx5AXEmFgBC5w e9Vmd91BkxXri9cftwlT3FoTSlgOGVMNAzIyvbzFrYEKB+pnnWuIDuKuvfDKK64pLIgN Zcb17yg/7glxA9qnOs3Qvqe1xl0z+59cccrzUqpNBwm1AYLEZSwCXxWDSL1D9YU2NRdm nZiA== X-Gm-Message-State: AC+VfDyI/p7/iE2ubZPJSoSkYIxGFDOy/5MKYZrXjZ8kcOcIfSD0wGzh n+YTpiV/9RIu9HJmjm5CSNNkzw== X-Google-Smtp-Source: ACHHUZ68FBDbyp3IZg1eUqXE2BCZnrZjNd4P42UygRisLbkhPgzzyOKJgvg5LmW18tMge+KhjJzHgQ== X-Received: by 2002:a92:dcc4:0:b0:338:18f1:db72 with SMTP id b4-20020a92dcc4000000b0033818f1db72mr248910ilr.29.1685981588701; Mon, 05 Jun 2023 09:13:08 -0700 (PDT) Received: from murgatroyd (71-211-130-244.hlrn.qwest.net. [71.211.130.244]) by smtp.gmail.com with ESMTPSA id d13-20020a02a48d000000b0041408b79f1esm2179673jam.111.2023.06.05.09.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 09:13:08 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [RFC 00/10] More use of unrelocated_addr References: <20230424162211.682763-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 05 Jun 2023 10:13:07 -0600 In-Reply-To: <20230424162211.682763-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Mon, 24 Apr 2023 10:22:01 -0600") Message-ID: <87mt1dsx9o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> While working on a different patch, I decided to add more use of Tom> unrelocated_addr to the DWARF reader. This caught at least one latent Tom> bug, see patch #10. (I thought there was another one as well, but I Tom> can't find it now.) Tom> The main ugliness here is that it adds a lot of casts. Partly (but Tom> not entirely) this is due to the decision to not use Tom> DEFINE_OFFSET_TYPE for unrelocated_addr. Maybe it would be better to Tom> write a custom wrapper class for unrelocated_addr instead. Tom> I moved unrelocated_addr to gdbsupport, but maybe it would be better Tom> in defs.h. I'm not sure. Tom> Regression tested on x86-64 Fedora 36. Tom> Let me know what you think. I rebased this and re-regression tested it. I'm checking it in now. Tom