From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 744733858430 for ; Fri, 26 May 2023 15:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 744733858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685116385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wPkrVz5Q0YnGEIWfZ2pcIirmm9GulXjIv7Gu1AAZTf8=; b=d2ea6SotW2BXIz4J93/bwODDrY8UGetgP33CurXmkqHbSlOzHZtom+H78QcpMuQGB5+cYa hGielv4Mwdl06915ZxPiwuPAB2ne3Cnv3ZMSb7E3thhSlQibyz4C7UvBMkUTwMkAcIIdfE v7BR0629p4zpnl8zsnU0ukKLjhwt7As= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-Mjwdk1QRPc6ifyHeSgg6dg-1; Fri, 26 May 2023 11:53:03 -0400 X-MC-Unique: Mjwdk1QRPc6ifyHeSgg6dg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f4dd7f13d0so4516605e9.3 for ; Fri, 26 May 2023 08:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685116382; x=1687708382; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wPkrVz5Q0YnGEIWfZ2pcIirmm9GulXjIv7Gu1AAZTf8=; b=Ae1DKxo6M0aBzwByzWNk37vLXcUC5SH1HH6z9f8+xOEGHAkK+1shsC0Ysa02tfcNyu dcGAGEjG/yLfM8uytb+9zkBSyghCRTcZ21xKKVX1PbkJxJwzVCbczVZg9NSbbjmPOPzC Bmh++jxlYs9W5yc++w9Y8nTWn6RJNQQqEIqV1Ry2AO2/ww5WF500arBvF39F+RrS1e0+ /Z/4VS0FZzcEcUyzb1M/ZJr2Da2c130RqG2elW8smCz5uHhvYCg+tW89qYAhVsfskUzM bX2BT9QUmCwKmiaGpVqAozI8E/BVUGSGdOKNZfjxxJoD1/oa4O62ru/a1ojGCDOBE2Ah soqw== X-Gm-Message-State: AC+VfDzRpQv2gEAuDqSiAjpzI1OXzUTnaJbBaYvdL7l8aC6lJEHfD9GX wuQ8qahrnicEAy2L15m1vdJTsHPitTGegV2DWn4nT1k59wM9ZeDPiINTbKnN1PP6jhAdeva5w5Z 5LlX9UVJtgp7WbRRY5N53TZY3X/qybA== X-Received: by 2002:adf:f98b:0:b0:309:36e9:5834 with SMTP id f11-20020adff98b000000b0030936e95834mr1727448wrr.61.1685116382628; Fri, 26 May 2023 08:53:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rvQ98eJHalDfvrvj/qkUa02QaE5hPIBmdR4SyhPX0DjbdjDxrRVcsyVjIGwHxLPYDpGYQzw== X-Received: by 2002:adf:f98b:0:b0:309:36e9:5834 with SMTP id f11-20020adff98b000000b0030936e95834mr1727436wrr.61.1685116382345; Fri, 26 May 2023 08:53:02 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id r2-20020a5d4e42000000b003095bd71159sm2031795wrt.7.2023.05.26.08.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 08:53:02 -0700 (PDT) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 06/31] Avoid duplicate QThreadEvents packets In-Reply-To: <20221212203101.1034916-7-pedro@palves.net> References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-7-pedro@palves.net> Date: Fri, 26 May 2023 16:53:00 +0100 Message-ID: <87mt1r5btv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > Similarly to QProgramSignals and QPassSignals, avoid sending duplicate > QThreadEvents packets. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 > --- > gdb/remote.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdb/remote.c b/gdb/remote.c > index a7430eb79dd..41348a65dc4 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -314,6 +314,10 @@ class remote_state > the target know about program signals list changes. */ > char *last_program_signals_packet = nullptr; > > + /* Similarly, the last QThreadEvents state we sent to the > + target. */ > + bool last_thread_events = false; > + > gdb_signal last_sent_signal = GDB_SIGNAL_0; > > bool last_sent_step = false; > @@ -14507,6 +14511,9 @@ remote_target::thread_events (int enable) > if (packet_support (PACKET_QThreadEvents) == PACKET_DISABLE) > return; > > + if (rs->last_thread_events == enable) > + return; > + > xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0); > putpkt (rs->buf); > getpkt (&rs->buf, 0); > @@ -14517,6 +14524,7 @@ remote_target::thread_events (int enable) > case PACKET_OK: > if (strcmp (rs->buf.data (), "OK") != 0) > error (_("Remote refused setting thread events: %s"), rs->buf.data ()); > + rs->last_thread_events = enable; > break; > case PACKET_ERROR: > warning (_("Remote failure reply: %s"), rs->buf.data ()); > -- > 2.36.0