From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 7B5BB3858C52 for ; Mon, 10 Apr 2023 14:38:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B5BB3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x136.google.com with SMTP id s4so2346472ilv.11 for ; Mon, 10 Apr 2023 07:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1681137524; x=1683729524; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xF8utIXam8CXaeDadD8sX4d2aONAGneXP/bhUe9TuWk=; b=kXYV8e0D1gHmE7Kr2H7bLcrw0ijSzbxa6cviZDaNrfvtQ9jB9SovNFKxEV28QCL8cT Pxp8B/U5rFqRqtgjyxbmMExo7hIlpqwS5vClF8TJT07OOE9RAV2pj0E9yX6SqV6VQHs9 6jLmYJvTwbfeXnTgwlPWpxLryIwHSu7URadYUT/txAzI24WORJRZgLQDIDFFMMxIzAv+ 9UqtlzIAJ3+BP6ftKCODZR7dszij1Invmr13CnH/aq/3d4U6LDfUN8GFBEAiA6KRgOzM 1txkx1qhrx3hRWiRboMMwaVMZ4U5NnvgeRTKnGCJPHxEbV6Orlu8Tj6tKhJlpNODWhDO su3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681137524; x=1683729524; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xF8utIXam8CXaeDadD8sX4d2aONAGneXP/bhUe9TuWk=; b=K8hwFXdQurKctRlM7NWmcnIVbXPLLBXhiSgDQ7tl2fIFggbmtTuuG0LeOSDzNTQKB9 5GUG3AEU4OSMU3bUAniDm1/ELx7Z+I5dXdyg1slBnfh/m+Iz0g+N4vcC4YwX9p0QwToY +E8bwOxvwIkUMhUuYwFiU0vXwIOFLYRSyziwZNy1frhTr93T2dFmccMOlteOrZKDKfnZ KEWIepVnI6J90oeWSkXFQXh8RA6TdEeGjtHjeW6/rzsvz/EUpfi4T7fgSUK6cmcs8KIy w0ImcDheD9UaLZLDcT07O8wNv53KnKduyij68+4sdaO48RyszhaUShmYC/gOamRXgM4/ diNg== X-Gm-Message-State: AAQBX9cwAbCAF2UYhZMTl7ctZnz/Hl1T6WN0SqIYGAPeXjduF/3XXPuf l+bgccwTQBACpvlt06Qgm46BDkk/34k2pK9sdqM2WA== X-Google-Smtp-Source: AKy350bFq8K/sPJulZeEoc+sFbIPYRltqc0rA01BioccWqSWK1PO9+iV8198lfBQVYlBDkr5q52TsA== X-Received: by 2002:a92:c74b:0:b0:328:c67f:509d with SMTP id y11-20020a92c74b000000b00328c67f509dmr1589483ilp.20.1681137524742; Mon, 10 Apr 2023 07:38:44 -0700 (PDT) Received: from murgatroyd (75-166-159-36.hlrn.qwest.net. [75.166.159.36]) by smtp.gmail.com with ESMTPSA id a3-20020a029403000000b0040bc0a9e711sm1308380jai.88.2023.04.10.07.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 07:38:44 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Handle unwinding from SEGV on Windows References: <20230321194240.1766622-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 10 Apr 2023 08:38:43 -0600 In-Reply-To: <20230321194240.1766622-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 21 Mar 2023 13:42:40 -0600") Message-ID: <87mt3f7qfg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> PR win32/30255 points out that a call to a NULL function pointer will Tom> leave gdb unable to "bt" on Windows. Tom> I tracked this down to the amd64 windows unwinder. If we treat this Tom> scenario as if it were a leaf function, unwinding works fine. Tom> I'm not completely sure this patch is the best way. I considered Tom> having it check for 'pc==0' -- but then I figured this could affect Tom> any inaccessible PC, not just the special 0 value. Tom> No test case because I can't run dejagnu tests on Windows. I tested Tom> this by hand using the test case in the bug. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30255 I'm checking this in. Tom