From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 197813858C50 for ; Sat, 18 Mar 2023 15:56:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 197813858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 4AD9E10047FAA for ; Sat, 18 Mar 2023 15:56:56 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dYvQplPA2NX2adYvQpRn4M; Sat, 18 Mar 2023 15:56:56 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=6415df48 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=dNGiwFb4lXTdtkEs_0cA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/cBj15uuf+wwy7WyNWBdwA6itxYJVcjrQrF0ApBo3Pg=; b=Dkoq3zd+BY72AU+CRZdhh3PrKC il6uzRjBlttPsuJYLV3BdcongBrN5KG5HtvUOcHmxJAZQmuIPjyYW/BMSEzbZFJefQCVGuBbGQBUe GEUsCLd4kn7fsxz8C7gRRyIt5; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:51474 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pdYvQ-000mo5-1w; Sat, 18 Mar 2023 09:56:56 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 14/20] Use type allocator for range types References: <20230313-split-objfile-type-allocator-2-v1-0-69ba773ac17b@tromey.com> <20230313-split-objfile-type-allocator-2-v1-14-69ba773ac17b@tromey.com> <264a76f6-c222-fc96-66d2-35e488b4a7b3@simark.ca> X-Attribution: Tom Date: Sat, 18 Mar 2023 09:56:52 -0600 In-Reply-To: <264a76f6-c222-fc96-66d2-35e488b4a7b3@simark.ca> (Simon Marchi's message of "Tue, 14 Mar 2023 10:41:39 -0400") Message-ID: <87mt4aaw8r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pdYvQ-000mo5-1w X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (prentzel) [71.211.185.113]:51474 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> +extern struct type *create_static_range_type (type_allocator &, struct type *, >> LONGEST, LONGEST); Simon> I don't know what you think about declarations without names, but when I Simon> touch one, I try to add the names. Especially if the comment refers to Simon> them, it makes things a bit clearer. Yeah, that makes sense. I went through this series and did that in every spot I touched. Tom