From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 9CBB03857C51 for ; Thu, 2 Mar 2023 15:50:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CBB03857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12d.google.com with SMTP id r4so10640292ila.2 for ; Thu, 02 Mar 2023 07:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1677772250; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yfM//W+q8GVK+sKIABpzuDHLPbw18yLl7Z3WD7QYL0M=; b=VUw/4v6jS2swcPqokuhqtyJN+aphzwlrnKYr5Bvgzdw1fB8cJG+DeSdw3XZ7k4NirO WYhSJv91IyiHxyLJ5MeYoRG1p4PRm+/M+Hnt/6/TdVFfU0CANkELcQ+oBnErTlkJanOm ZyIbglwZmDwGEYs4XWFqCNEnUw1+k0U4jIejX1JcIbys9OtrEQeC2naVL9f0SNSkq43Z AwaP5COo74mcYDw5f+Ae+XZAdZ2U6kngoBIMO4RRrBsNMAcfr9BVWwNKwiXwoFY0RV/x AtGPc99TyMXAYgZ8gHInCGc0kt8K4FNJk29h/tTkhBmKkyj1ptVBJCx1MWHXUgK/2IPF DoRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677772250; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yfM//W+q8GVK+sKIABpzuDHLPbw18yLl7Z3WD7QYL0M=; b=qbs5VwRl/MTQbq5RlwKiXxzbcb6AbFCWOjKMEjvnKJhFuxziVCY+ekZpBBnlAQj9Bh oQCZgbTBvPSwx3XO0coE37PNu8WgU54qiqp5jDZGejdysutjvYhakh1c0UaIdoqAQ5Kw WTAqvRGXbpb3R0Et7wOY2tf2IuQlg0nIFvi9D/QxZ6mOCFLaRKyt68E3J8FfEyrFTygE 8Jqj2JdtLPcwTyMEdRVw0cWNV3CvEGEGyqbPgGbcjenSK5i5YD8M7hcHUCw0IsNhRF9x 24RnGl/TSGgzvHgffqXqK56ufvAe6vhhLQ48A69/no8zD9tqacQWZcgXq3NoQMx4QUp7 fe3g== X-Gm-Message-State: AO0yUKU+WBk1Q1/ohj+hXI9WXKepfESyue47LAUnPqk/28HpHSGfeh0n mbeF/jJ8KVw1yl0PuMmWu1g+aaSAc/MdF69/ X-Google-Smtp-Source: AK7set81xBWWEbWw7s9eG65sacvuphrraI1mTRF2j1cA5B6OF0q9R5Zv/U8n6G0zKkSUk4NFWJmnrA== X-Received: by 2002:a05:6e02:2169:b0:315:4c1c:f9db with SMTP id s9-20020a056e02216900b003154c1cf9dbmr9658416ilv.19.1677772249911; Thu, 02 Mar 2023 07:50:49 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id y7-20020a92c987000000b00316ef6e729dsm4523260iln.40.2023.03.02.07.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 07:50:49 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Handle half-float in 'x' command References: <20230224163834.2675084-1-tromey@adacore.com> <58b76ee1-d004-14a3-a47e-2108e5aa7e62@simark.ca> X-Attribution: Tom Date: Thu, 02 Mar 2023 08:50:48 -0700 In-Reply-To: <58b76ee1-d004-14a3-a47e-2108e5aa7e62@simark.ca> (Simon Marchi's message of "Wed, 1 Mar 2023 21:21:52 -0500") Message-ID: <87mt4vb19j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> Can you add a comment before the section you added, to indicate what it Simon> intends to test? I mean to say, I did it. Thanks for the review. Tom