From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id E76523858D32 for ; Sat, 18 Feb 2023 00:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E76523858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 6B2C510047D9F for ; Sat, 18 Feb 2023 00:01:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id TAf5pv9JpBkq3TAf5p58hs; Sat, 18 Feb 2023 00:01:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DdHSFthW c=1 sm=1 tr=0 ts=63f01543 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=XOLoEakWZjPiRM1jZ_cA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h8ZoCZSY4jMDrbFRk6sYR+l6i6SnPPtPqhfmrSKlNhg=; b=Ukpq2b9NuwHTi3VwhKB+KzYrNd +jfDy+eXjlQBIxM3xQ+YAoCF3ZKfhs++6ARf60yeOkutc4xHPPOpekTwWY5g2P6OnVdG5x6hxOuSA Omz1/yBmUDQ70MKZaP1aYcIs0; Received: from [172.58.60.111] (port=61747 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pTAf4-002Kt0-W7; Fri, 17 Feb 2023 17:01:07 -0700 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Avoid manual memory management in go-lang.c References: <20230216-submit-go-unique-ptr-v1-0-73dd8065c6a6@tromey.com> <20230216-submit-go-unique-ptr-v1-1-73dd8065c6a6@tromey.com> <87edqnlxoc.fsf@redhat.com> X-Attribution: Tom Date: Fri, 17 Feb 2023 17:01:01 -0700 In-Reply-To: <87edqnlxoc.fsf@redhat.com> (Andrew Burgess's message of "Fri, 17 Feb 2023 22:44:19 +0000") Message-ID: <87mt5b970i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 172.58.60.111 X-Source-L: No X-Exim-ID: 1pTAf4-002Kt0-W7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [172.58.60.111]:61747 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> +/* Given a Go symbol, return its package or NULL if unknown. */ >> +extern gdb::unique_xmalloc_ptr go_symbol_package_name >> + (const struct symbol *sym); >> + >> +/* Return the package that BLOCK is in, or NULL if there isn't >> + one. */ >> +extern gdb::unique_xmalloc_ptr go_block_package_name >> + (const struct block *block); Andrew> Maybe replace NULL with nullptr in these comment. But otherwise, this Andrew> all looks great. I've done this, thank you. Tom