Re: [PATCHv2 4/6] gdb: error if 'thread' or 'task' keywords are overused

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: Andrew Burgess <aburgess@redhat.com>
>> Date: Fri, 20 Jan 2023 09:46:27 +0000
>> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>> 
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -9,6 +9,15 @@
>>    This support requires that GDB be built with Python scripting
>>    enabled.
>>  
>> +* For the break command, multiple uses of the 'thread' or 'task'
>> +  keywords will now give an error instead of just using the thread or
>> +  task id from the last instance of the keyword.
>> +
>> +* For the watch command, multiple uses of the 'task' keyword will now
>> +  give an error instead of just using the task id from the last
>> +  instance of the keyword.  The 'thread' keyword already gave an error
>> +  when used multiple times with the watch command, this remains unchanged.
>
> This part is OK, but I wonder whether we should provide an example of
> such incorrect usage which will now be flagged, because I'm not sure
> everyone will understand what "multiple uses" means in this context.

I've now written:

  * For the break command, multiple uses of the 'thread' or 'task'
    keywords will now give an error instead of just using the thread or
    task id from the last instance of the keyword. e.g.:
      break foo thread 1 thread 2
    will now give an error rather than using 'thread 2'.
  
  * For the watch command, multiple uses of the 'task' keyword will now
    give an error instead of just using the task id from the last
    instance of the keyword. e.g.:
      watch my_var task 1 task 2
    will now give an error rather than using 'task 2'.  The 'thread'
    keyword already gave an error when used multiple times with the
    watch command, this remains unchanged.

How's that?

Thanks,
Andrew