From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix comparator bug in cooked index
Date: Mon, 30 Jan 2023 10:46:56 -0700 [thread overview]
Message-ID: <87mt5zoqy7.fsf@tromey.com> (raw)
In-Reply-To: <5ebb2d7e-392f-af15-5d85-8837d3febb68@simark.ca> (Simon Marchi's message of "Mon, 30 Jan 2023 10:15:45 -0500")
>> This is v2. I believe it addresses the review comments, except for
>> the 'enum class' change, as I mentioned in email on the list.
Simon> This LGTM:
Simon> Approved-By: Simon Marchi <simon.marchi@efficios.com>
Thanks. I'm going to check it in, and also backport it to the gdb 13
branch.
Tom
prev parent reply other threads:[~2023-01-30 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 14:56 Tom Tromey
2023-01-30 15:15 ` Simon Marchi
2023-01-30 17:46 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt5zoqy7.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).