From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 6A0183858407 for ; Mon, 30 Jan 2023 17:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A0183858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id m8so5432273ili.7 for ; Mon, 30 Jan 2023 09:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vTF7fkluPYPWLdcR8pHjhB3/NgoYKTYkva8+niMT+yI=; b=LzRNmIrm5Gjj9YilOp4vCh/BRbN1sYEuNOyJS0QoOkzza6jSVDA0jxsWJGhNZq38YW z6c8PFLsRCI7/iWUjmmLF4noOjvGm2WZ/PNR1ouRMNlpCOM5yNlRcizWZ+8yQz18345k fbLeEHKRFQDS3ZDdffZsOJV/sXXXEMY+l4NdSxa53d9/1Z2F84kqjMPoZeenqVgg0fFB yNSP8MG1HJwUhY+oD9jokPat/5Oyenj8pWeyD9wwu/YuUxcKXc6X3s5W2qrcuaoXPGfK 8qZW4cxiGiIqq18XxUEABD9rjegsGdPWHp7JgoVnqqdHFfExmtsA8iRTV5JV07OQiD8q RbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vTF7fkluPYPWLdcR8pHjhB3/NgoYKTYkva8+niMT+yI=; b=M7kTLVttuE2d90TGbmGX/Qlahifv10ojn8ZHAhHBoOtpuZ2DB4YC07BodUzo6pZFpY PSKgkgeGBh5TNKftYRpcn4bh+kkcCeh2G7sTy5oUdRjm5uoLEd8k2haLSrCAtnNKDNGk 3BdBISXy3ZfwkHCNFuVnS8fwwvDGMQ8qhJE94w1cYKcWmBNRwI/eerv0XF6EeJqco1kn Xt9Ql8rHIobqSGiDHzGEQ3oHeHCUhtJ4T4FyGvWqFMWD5wYOSZiQO0HsMAWIFkoIczqL iS2FsuFnrmHiB45qUR9KIFxWRJrO7FwVYMbVByhJpdtNQ0H0wmtFjvyV+kgyjc5yVU9t PTQA== X-Gm-Message-State: AO0yUKWQ+lebbZ1sFXqCF1vXY9wNkKJoxa0HRiH9gGUYpf8tZvIdgRh7 CoebpSBPNk4uZ3qZYz4/Vjx8NtEZPRBWK9/K X-Google-Smtp-Source: AK7set/ZNb1i2HmZinZsLvR7tL1dVGnxxq7nzi40wP52UZFmo92BrQp90izYinZFNChpC37YmNO+Wg== X-Received: by 2002:a05:6e02:1524:b0:310:af48:ab2 with SMTP id i4-20020a056e02152400b00310af480ab2mr14909863ilu.23.1675100817687; Mon, 30 Jan 2023 09:46:57 -0800 (PST) Received: from murgatroyd (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id a11-20020a02734b000000b003a5d8834734sm4929529jae.45.2023.01.30.09.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 09:46:57 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix comparator bug in cooked index References: <20230130145617.1619439-1-tromey@adacore.com> <5ebb2d7e-392f-af15-5d85-8837d3febb68@simark.ca> X-Attribution: Tom Date: Mon, 30 Jan 2023 10:46:56 -0700 In-Reply-To: <5ebb2d7e-392f-af15-5d85-8837d3febb68@simark.ca> (Simon Marchi's message of "Mon, 30 Jan 2023 10:15:45 -0500") Message-ID: <87mt5zoqy7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> This is v2. I believe it addresses the review comments, except for >> the 'enum class' change, as I mentioned in email on the list. Simon> This LGTM: Simon> Approved-By: Simon Marchi Thanks. I'm going to check it in, and also backport it to the gdb 13 branch. Tom