From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 6767C3858C00 for ; Fri, 27 Jan 2023 14:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6767C3858C00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 58AD910048ECB for ; Fri, 27 Jan 2023 14:24:24 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id LPeSpDDGZc5SPLPeSppXyZ; Fri, 27 Jan 2023 14:24:24 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=e7bD9Yl/ c=1 sm=1 tr=0 ts=63d3de98 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=-zsurM_vzbfwaQopP6IA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gfc/2YLPJ0o5RGobN0Lw6hR2LzRsrYPEC3bvWEt0R48=; b=EbQsNZmLJg6TKfU1HjxudQLBhU RuuH53ETmWJXGG+gL2HTkAwxAORCObc4ZXf+6N2JIMt0BP2aRoa/MARtT686zoIDPUpB22HiASM53 yU5FX+ygo54Y0wEy9yQHi61NZ; Received: from 75-166-146-144.hlrn.qwest.net ([75.166.146.144]:59624 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pLPeQ-002SwN-Oa; Fri, 27 Jan 2023 07:24:23 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump References: <20230127051317.700077-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 27 Jan 2023 07:24:22 -0700 In-Reply-To: <20230127051317.700077-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 27 Jan 2023 00:13:17 -0500") Message-ID: <87mt64qcmh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.144 X-Source-L: No X-Exim-ID: 1pLPeQ-002SwN-Oa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-144.hlrn.qwest.net (murgatroyd) [75.166.146.144]:59624 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The cooked_index_functions::dump function is called as part of the Simon> "maintenance print objfiles" command. I tried to make the output Simon> well structured and indented to help readability, as this prints a lot Simon> of text. Thanks for doing this. Simon> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c Simon> index cd937f24ee74..73aafbed80b4 100644 Simon> --- a/gdb/dwarf2/read.c Simon> +++ b/gdb/dwarf2/read.c Simon> @@ -93,6 +93,7 @@ Simon> #include "split-name.h" Simon> #include "gdbsupport/parallel-for.h" Simon> #include "gdbsupport/thread-pool.h" Simon> +#include "inferior.h" Simon> /* When == 1, print basic high level tracing messages. Simon> When > 1, be more verbose. Simon> @@ -18588,7 +18589,78 @@ struct cooked_index_functions : public dwarf2_base_index_functions Simon> void dump (struct objfile *objfile) override Simon> { Simon> - gdb_printf ("Cooked index in use\n"); Simon> + gdb_printf ("Cooked index in use:\n"); Simon> + gdb_printf ("\n"); I think I'd rather have the bulk of the dumping in the cooked-index code instead of here. Simon> + Simon> + dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); Simon> + Simon> + cooked_index_vector *table Simon> + = (gdb::checked_static_cast Simon> + (per_objfile->per_bfd->index_table.get ())); Like right here could be a method call. The cooked index dumper should probably start with a call to 'wait' to ensure that no background work is being done. Simon> + const char *start_addr_str Simon> + = paddress (current_inferior ()->gdbarch, start_addr); I was curious why the inferior.h include was needed. I suspect the objfile's arch is preferred here. Tom