From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 7DD033858D20 for ; Fri, 2 Dec 2022 19:07:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DD033858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x329.google.com with SMTP id m7-20020a9d6447000000b0066da0504b5eso3466088otl.13 for ; Fri, 02 Dec 2022 11:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=+auwU1FHkb3aoWiB80/w0smNE/L9aFpU+3wg4OAh7oQ=; b=rTb1Og3jk8fJG4oOObMmlJfb3wj+ewDiIOLpzmlpVQI3RPt3lkGzVIhMqXRkHURC5K XL8s/Gnd0lDBfV14QbGU8sLqJLrPMCtnha8RTHNAi1S9xm6LCMu61k3LvpgoaWZJDVaC GjQ+5qY4NWOgedb+oKNE2/y3ZyWe8/YEscTnwPDwGvOuI4rRlpQDCi0xWniPqGhyKoRI wxYksZU9Hi+0LXtX47VJ39dskASy2E0UuhzXgrMjxeTFqPnzBNDc3Q0Zg/AaBDlnBr0u 6P8dt8GKdnkIDpU/lk9rZm7ZeWHeBvtWQznOWL3gMvGkmiErc2x9ycjcpsATuUga2MvP ae1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+auwU1FHkb3aoWiB80/w0smNE/L9aFpU+3wg4OAh7oQ=; b=zAZufB+2uRXxkn2pgnSGC4NCwLlyaNoSNRW1Aeij2r7tQjiI2axfNRlAPe7EZD0mpm C6XML5Ryg7mrfY+wEu1AvDDxJAlElYPocvpF+ysIR6pRiVxDxPE8gauAmJ90nuayY/0D /5Yv3x8A3yr7xXA5MwEPDixyTxeKb7jfbxaR8kIB2ANo38Kl/sFh/PTzqOQCIT9+lbwf gNe58QQpD1dtQGOjjlIY0pL+PHi+FcICRYC79GbVnYsNcv1EgiiyEHl+tnF3KY19MhG0 pY8KLLJ3PV+PUKXI8tc3U6ObYDBitMxnfmvVWseEOZQ56t6+DeEqbfJ29Xvgml6lUafu jHIg== X-Gm-Message-State: ANoB5plf9k1yJypiei79LM577hi5lJynmwGBJqzgbeXK7mA97c42NIta 1caXkNGwaOgo76G9KQe7Hn3LhDZtf12YNeZG X-Google-Smtp-Source: AA0mqf6tat9OgikilxYNDb76zvOvRuSMHYCRA1LmaTkNP9nQ/H9CbJPYd2ROfErG20rkPhDWDgM+9A== X-Received: by 2002:a05:6830:b:b0:66d:67cb:ea16 with SMTP id c11-20020a056830000b00b0066d67cbea16mr26964763otp.243.1670008070839; Fri, 02 Dec 2022 11:07:50 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:2982:38ed:93ad:52f1]) by smtp.gmail.com with ESMTPSA id fp43-20020a05687065ab00b00140d421445bsm4557640oab.11.2022.12.02.11.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 11:07:50 -0800 (PST) References: <20221201223914.366184-1-thiago.bauermann@linaro.org> <20221201223914.366184-2-thiago.bauermann@linaro.org> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdbarch.py: Fix indentation in the generated gdbarch_dump function In-reply-to: Date: Fri, 02 Dec 2022 19:07:47 +0000 Message-ID: <87mt85fwu4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Simon, Thank you for the prompt review! Simon Marchi writes: > On 12/1/22 17:39, Thiago Jung Bauermann via Gdb-patches wrote: >> Use tab for the first eight spaces of indentation, and align the gdb_printf >> arguments to the open parenthesis of the function call. > > LGTM, but please run black as documented here to re-format the .py file: > > https://sourceware.org/gdb/wiki/Internals%20GDB-Python-Coding-Standards Sorry, I forgot about that step. Done in v2. > After that: > > Approved-By: Simon Marchi Thanks, added to the commit message. -- Thiago