From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id CEAF8384F02F for ; Thu, 10 Nov 2022 18:26:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CEAF8384F02F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 4C09E1004551D for ; Thu, 10 Nov 2022 18:26:22 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id tCFqoHyQTHAbttCFqoNydM; Thu, 10 Nov 2022 18:26:22 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=OZxdsjfY c=1 sm=1 tr=0 ts=636d424e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=O0yLpECJzEwnovZ1YYoA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rHIbDe3CUgDKoBELgLOvwJ9uJj9AvIWVYzWOn1FNmco=; b=A/JKwQXZM6H1VdKSy46kzrTigt QiBMMqhaJ/es0bAhrrkKSCdA1gbfYTI26+Cn8HX1Cz9GCQMKqXdqL7X+rjNs53x/7d7CMqUI3W/yX sAPNHlLlND+jLPO9Oo4MPtFhE; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56832 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1otCFp-003CI5-Go; Thu, 10 Nov 2022 11:26:21 -0700 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Lancelot SIX , , , Subject: Re: [PATCH v2] gdb/py-inferior: Keep inferior threads in a map References: <20221109185120.1828613-1-lancelot.six@amd.com> X-Attribution: Tom Date: Thu, 10 Nov 2022 11:26:19 -0700 In-Reply-To: <20221109185120.1828613-1-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Wed, 9 Nov 2022 18:51:20 +0000") Message-ID: <87mt8yy8c4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1otCFp-003CI5-Go X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56832 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> ">" == Lancelot SIX via Gdb-patches writes: >> Changes since V1: >> - Changed the implementation (and description) to use std::unordered_map >> instead of std::map. >> - Added a comment in delete_thread_object to explain why we do >> "it->second->thread = nullptr" as this is easy to miss. >> - In infpy_threads: move i's increment outside of PyTuple_SET_ITEM to >> avoid issues if this is or becomes a macro evaluating its arguments >> more than once. Thanks, this is ok. Tom