From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 73590382DE06 for ; Wed, 26 Oct 2022 15:54:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73590382DE06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666799649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bZ8nkOhJjjO3+zyKMtUQPFdGKWmqtOJQRF8RbGiSU+I=; b=hhHaFDzZKfFShYHHq7wpNCicKeJ2+wusyNnkkPNQVO/LafNxIcruD7bTK6wrMgb7QdPdR7 2IO4CaOyQ9JUT7OdSkOnHhy4uezfQtJvg3my/gK1jLGFL5n6HJ6R3o13ZW+dblBUMLPcm+ 3JRDU9XIez7n9o+IUjeZuvYh5RGv2Tc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-367-Yb0pyV_aMHS8y_paA4kQ8A-1; Wed, 26 Oct 2022 11:54:08 -0400 X-MC-Unique: Yb0pyV_aMHS8y_paA4kQ8A-1 Received: by mail-wm1-f69.google.com with SMTP id l1-20020a7bc341000000b003bfe1273d6cso602222wmj.4 for ; Wed, 26 Oct 2022 08:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bZ8nkOhJjjO3+zyKMtUQPFdGKWmqtOJQRF8RbGiSU+I=; b=bnYH3Rrnu2E8/FO3shJMYAkErlBmt7sNiL4PYspaaPXOftm7O1jiuAr1EAyt5Bmd3U rb2izEt60zHEHoDWwzCplJqtQU3wNzgvdO+70h/liBSUkwDXEs0xiZMpj1UNrd1FoZj1 MwgnCxa1RY+w366Zkxq5h9iFsIPk8/kEV0ykl0qYVLsvNGMIISAq8Uvmf+qeDt04om1n gTPLSdINk35FKIpbD+empI7L+CKrXg/g7WdTmgjmWFp+NJrwEGePw3hs5HQ79a8C0cGx UMjbX0HEKHT1Qi9Seh5M3NrQPmZMSW+vjMx8SVDCISosnKoYCz2NGJg7Uw33eQBMLGjE KgZg== X-Gm-Message-State: ACrzQf25wiV5ERGLC5qFV1TeDFaJEgJbshaqP4Cc7bjNSBOCOoUIsDE+ XoXdqKG86guTGQQBc6onM5o3rZYdkALSw3VPJ3NguM6gsgr+n8zYm2XKbsEvmPGaZovwS/Zf3tc Giy/guJr9dgsz11uy7FXtQw== X-Received: by 2002:a5d:6ac6:0:b0:236:84b5:6660 with SMTP id u6-20020a5d6ac6000000b0023684b56660mr5310645wrw.555.1666799647101; Wed, 26 Oct 2022 08:54:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7HKkfext84pGa25LS81lv4Nalmy7dCIZfTzjhBeYrhZavLVwILL+DSkfRNjmCpjPK5n7+K9g== X-Received: by 2002:a5d:6ac6:0:b0:236:84b5:6660 with SMTP id u6-20020a5d6ac6000000b0023684b56660mr5310635wrw.555.1666799646943; Wed, 26 Oct 2022 08:54:06 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id h17-20020a056000001100b0022e66749437sm5685651wrx.93.2022.10.26.08.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 08:54:06 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH 09/11] gdb/testsuite: fix gdb.cp/converts.exp to run with clang In-Reply-To: <20221004170747.154307-11-blarsen@redhat.com> References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-11-blarsen@redhat.com> Date: Wed, 26 Oct 2022 16:54:04 +0100 Message-ID: <87mt9i60o3.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno Larsen via Gdb-patches writes: > Clang attempts to minimize the size of the debug-info by not adding > complete information about types that aren't constructed in a given > file. In specific, this meant that there was minimal information about s/In specific/Specifically/. > class B in the test gdb.cp/converts.exp. To fix this, we just need to > construct any object of type B in that file. > --- > gdb/testsuite/gdb.cp/converts.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.cp/converts.cc b/gdb/testsuite/gdb.cp/converts.cc > index ecf806481fd..1224581a879 100644 > --- a/gdb/testsuite/gdb.cp/converts.cc > +++ b/gdb/testsuite/gdb.cp/converts.cc > @@ -55,7 +55,7 @@ int main() > > char av = 'a'; > char *a = &av; // pointer to.. > - B *bp; > + B *bp = new B(); LGTM. Thanks, Andrew > foo1_1 (a); // ..pointer > foo1_2 (a); // ..array > foo1_3 ((int*)a); // ..pointer of wrong type > -- > 2.37.3