From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4A9E5385043B for ; Thu, 20 Oct 2022 15:59:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A9E5385043B Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-264-FhmHKHFxMM6WTV3qPEHVxA-1; Thu, 20 Oct 2022 11:59:07 -0400 X-MC-Unique: FhmHKHFxMM6WTV3qPEHVxA-1 Received: by mail-qk1-f197.google.com with SMTP id x22-20020a05620a259600b006b552a69231so195075qko.18 for ; Thu, 20 Oct 2022 08:59:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fjsmKxQ6tMIFcMyBU3AGVkX+ECiLeinydYMEhCmRyv0=; b=RdYRlwUsLQuLxkQOQM8QL6NaKJkF1oCHR1sQ/xldAk5OqUEPvh4WLtCB+fD1gjneY1 ZPrPd4AY+9kuWj9wsPn52njB5ebFf0VjItO1CFxoi8Hbm/82KzGatylpMmOPcj8cWxNt FfDGKPbeL/gvX2YUa7wIWZ1LL3Le/Ljfga0siUoKFkeZUZF3bWtmO2u9DUZJCp8rydLm z1LAsiXGzHArpk/Ls4rBYcaDBMSxwMH3fQaWdNdarrCc4rMWsOSAmI8b/OQGGFG74Ec7 sEJjMXtube/SVIja1b844nq3Lcg9CYi3gCmljkv4BtSMV+qcg2kNeKQDKK/5IhCIR+gI NWkw== X-Gm-Message-State: ACrzQf3zKB3ZMJ+x4QB4l/p/AZp4+aemwwG1374pRchK64mGmLg58F3N TjTIBbV6ZRh3WSotBDXQKx6CmzSUt/VrG22zKqCw6zFSCAmDHx5Hjozgy5uXzDFYb1Rgh/teW4Z wk9FoBjfbyLwhWLoAwbfvag== X-Received: by 2002:ad4:596e:0:b0:4b6:3fb4:955e with SMTP id eq14-20020ad4596e000000b004b63fb4955emr11097694qvb.5.1666281546626; Thu, 20 Oct 2022 08:59:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5sMxyaxhGNLGh7NhTjaIWEWXyK0Cspc9J0Z+pD3nj1tyrnrLchRXgNIXKbw0iMkilZsVscUA== X-Received: by 2002:ad4:596e:0:b0:4b6:3fb4:955e with SMTP id eq14-20020ad4596e000000b004b63fb4955emr11097687qvb.5.1666281546438; Thu, 20 Oct 2022 08:59:06 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id y9-20020a37f609000000b006ce7cd81359sm7249554qkj.110.2022.10.20.08.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 08:59:06 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 2/3] gdb/python: break more dependencies between gdbpy_initialize_* functions In-Reply-To: <8735bqnxlu.fsf@tromey.com> References: <1e89f7f71a8170a1529697d1bfc9d971d89978f9.1664729134.git.aburgess@redhat.com> <8735bqnxlu.fsf@tromey.com> Date: Thu, 20 Oct 2022 16:59:04 +0100 Message-ID: <87mt9qa3lj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 15:59:17 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> After this commit a new function gdbpy_breakpoint_init_breakpoint_type > Andrew> exists, this function ensures that breakpoint_object_type has been > Andrew> initialized, and can be called from any gdbpy_initialize_* function. > > Andrew> I feel that this change makes the dependency explicit, which I think > Andrew> is a good thing. > > Me too. Thanks for doing this, I think you should check it in. I've pushed this patch, and will have a think about what to do with patch 3/3. Thanks, Andrew