Re: [PATCH] gdb/testsuite: handle invalid .exp names passed in TESTS

[Andrew Burgess <aburgess@redhat.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> Bruno Larsen <blarsen@redhat.com> writes:
>
>> Hi Andrew,
>>
>> Once again, very well timed patch as I had just noticed this problem! 
>> Other than a typo (response inlined), my only comment is that, since you 
>> are already renaming check-single, what do you think about renaming to 
>> check-single-thread or check-sequential?
>
> Except I'm not really renaming check-single.  I'm adding a dependency to
> check-single, and replacing the recipe for check-single.  But
> check-single itself continues to exist just as it did before.
>
> I'm not against renaming check-single to something else, but I think it
> should probably be done as a separate patch with its own justification.
>
>> My reasoning is that when first reading the message and diff, I thought 
>> this rule would test a single test, which left me confused for a minute.
>
> I can see that.
>
>>
>> Either way, I like the patch, and encourage you to approve it!
>
> I'll give this a little longer to see if anyone else has any thoughts,
> then I'll merge it.

I've gone ahead and merged this patch.

Thanks,
Andrew