public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [committed][gdb/symtab] Fix data race in ~charset_vector
Date: Thu, 14 Jul 2022 11:31:52 -0600	[thread overview]
Message-ID: <87mtdbsirb.fsf@tromey.com> (raw)
In-Reply-To: <20220714061923.GA543@delia.home> (Tom de Vries via Gdb-patches's message of "Thu, 14 Jul 2022 08:19:25 +0200")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> The problem is that we're freeing the charset_vector elements in the destructor,
Tom> which may still be used by a worker thread.

Could you say how this happens?
What is the worker thread doing?

Normally I think gdb should be waiting for background tasks to finish
before proceeding with this sort of destruction.  If this is coming from
the parallel DWARF reader, maybe we need some higher level API to
cleanly shut down those threads first.

Tom

  reply	other threads:[~2022-07-14 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  6:19 Tom de Vries
2022-07-14 17:31 ` Tom Tromey [this message]
2022-07-14 18:43   ` Tom de Vries
2022-07-15 14:34     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtdbsirb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).